New issue
Advanced search Search tips

Issue 914187 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 898324



Sign in to add a comment

qscheduler: return correct slice_number depending on whether provisioning is required for task

Project Member Reported by akeshet@google.com, Dec 12

Issue description

Currently, qscheduler always returns first slice, which is incorrect. First slice should only be returned for tasks where no provisioning is required.
 
Blocking: 898324
for posterity, will want a command like this to test with:

./swarming.py run --swarming chromium-swarm-dev.appspot.com --print-status-updates --timeout 9000 --raw-cmd --task-name akeshet/qstest --priority 50 --dimension os Ubuntu-14.04 --dimension pool ChromeOSSkylab-suite --io-timeout 9000 --hard-timeout 9000 --expiration 1200 '--tags=skylab:run_suite' -- /usr/local/autotest/bin/run_suite_skylab --build nyan_blaze-paladin/R73-11357.0.0-rc2 --board nyan_blaze --suite_name dummy --pool quota-metered
This is fixed and tested in staging by https://chromium-review.googlesource.com/c/infra/infra/+/1374810/1 and its stack, just need to land those to mark this fixed.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bb1f612cd2b43b2c31bfbf44486589e898ebe903

commit bb1f612cd2b43b2c31bfbf44486589e898ebe903
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Dec 14 18:37:25 2018

qscheduler: correctly handle workers with multiple provisionable labels

Prior to this, provisional label matching was too strict, and would only
match workers if their provisionable labels were an exact match to those
of the request. In reality, we only need the worker's label set to
contain all of the task labels. Therefore, fix this logic.

BUG= chromium:914187 
TEST=unit test added, verified to fail prior to behavior fix

Change-Id: I63a1f127ec3a9ad7657f2e12346aded8fa89a19a
Reviewed-on: https://chromium-review.googlesource.com/c/1375130
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19566}
[modify] https://crrev.com/bb1f612cd2b43b2c31bfbf44486589e898ebe903/go/src/infra/qscheduler/qslib/scheduler/scheduler_test.go
[modify] https://crrev.com/bb1f612cd2b43b2c31bfbf44486589e898ebe903/go/src/infra/qscheduler/qslib/scheduler/scheduler.go

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dc821cfff07e0d723a01a3d7b3528119be0cc6dd

commit dc821cfff07e0d723a01a3d7b3528119be0cc6dd
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Dec 14 23:22:27 2018

qscheduler: return correct slice number based on ProvisionRequred

BUG= chromium:914187 
TEST=None

Change-Id: I46089d44ff5d7b80eb13a944c55fe7146f86fc9e
Reviewed-on: https://chromium-review.googlesource.com/c/1374810
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19578}
[modify] https://crrev.com/dc821cfff07e0d723a01a3d7b3528119be0cc6dd/go/src/infra/appengine/qscheduler-swarming/app/frontend/qscheduler.go

Status: Fixed (was: Assigned)

Sign in to add a comment