New issue
Advanced search Search tips

Issue 914176 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Address failure of DumpAccessibilityTreeTest.AccessibilityVideoControls on single_process_mash_content_browsertests

Project Member Reported by lethalantidote@chromium.org, Dec 12

Issue description

After addressing the reason for the revert shown below, please update the TestExpectations. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4a238458d4031971ef7d00923e6ab43781eaa8

commit da4a238458d4031971ef7d00923e6ab43781eaa8
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Nov 30 01:51:47 2018

Revert "Reland "[Accessibility] Volume slider reads out level in percentages.""

This reverts commit faf5cdcc8d2d8900033692fa863403a16e9090c9.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612469 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmFmNWNkY2M4ZDJkODkwMDAzMzY5MmZhODYzNDAzYTE2ZTkwOTBjOQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/16665

Sample Failed Step: single_process_mash_content_browsertests

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> Reland "[Accessibility] Volume slider reads out level in percentages."
> 
> This is a reland of cf0717195ed5798c1970f4897682a1517c229e75
> 
> Original change's description:
> > [Accessibility] Volume slider reads out level in percentages.
> >
> > This CL makes it such that the volume level is read out as a percentage
> > in aria. This CL also amplifies how the accessibility information is
> > given to aria, by setting attributes instead of explicitly creating
> > accessibility nodes.
> >
> > Bug:   905024  
> > Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337298
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612160}
> 
> TBR=mlamouri@chromium.org, dmazzoni@chromium.org, thakis@chromium.org
> 
> Bug:   905024  
> Change-Id: Ie35c05c274dfd36f3e9ec0a32b587a98a62249d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1356007
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612469}

Change-Id: Icc1f84da3c66189f0d3b30108e0ab4330d4061f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:   905024  ,  910442 
Reviewed-on: https://chromium-review.googlesource.com/c/1356137
Cr-Commit-Position: refs/heads/master@{#612501}
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/content/test/data/accessibility/html/video-controls-expected-blink.txt
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/content/test/data/accessibility/html/video-controls.html
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc

 

Sign in to add a comment