New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 914166 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Dec 14
Cc:
edwardjung@chromium.org
█ helenepark@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Tab loading animation] Use indeterminate throbber for both connecting and loading states

Project Member Reported by pbos@chromium.org, Dec 12 
Since the determinate loading animation can get stuck we should evaluate using the throbber for both states. Suggestion is to use grey on connecting and blue on loading.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f84108be4e1179a974c9131d4f8261c241bd37

commit c7f84108be4e1179a974c9131d4f8261c241bd37
Author: Peter Boström <pbos@chromium.org>
Date: Fri Dec 14 01:34:37 2018

Use new-tab-animation throbber for loading state

Makes use of the same nondeterministic animation during connecting and
loading. After loading finishes we transition to the previous loading
animation as a fade-out effect.

Bug:  chromium:914166 
Change-Id: I623bdd5d7bdb3e96fd56a2b224f9990a32036d2c
Reviewed-on: https://chromium-review.googlesource.com/c/1372565
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616550}
[modify] https://crrev.com/c7f84108be4e1179a974c9131d4f8261c241bd37/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/c7f84108be4e1179a974c9131d4f8261c241bd37/chrome/browser/ui/views/tabs/tab_icon.cc
[modify] https://crrev.com/c7f84108be4e1179a974c9131d4f8261c241bd37/chrome/browser/ui/views/tabs/tab_icon.h
[modify] https://crrev.com/c7f84108be4e1179a974c9131d4f8261c241bd37/chrome/browser/ui/views/tabs/tab_renderer_data.cc
[modify] https://crrev.com/c7f84108be4e1179a974c9131d4f8261c241bd37/chrome/browser/ui/views/tabs/tab_renderer_data.h
[modify] https://crrev.com/c7f84108be4e1179a974c9131d4f8261c241bd37/chrome/browser/ui/views/tabs/tab_unittest.cc

Comment 2 by pbos@chromium.org, Dec 14

Status: Fixed (was: Started)
►

Sign in to add a comment