New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914151 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[Label Request] Rename Test-Layout to Test-WebTest, and update "Layout Test Failure" template

Project Member Reported by tkent@chromium.org, Dec 11

Issue description

1] Label Name: Test-WebTest

Request to rename the existing label "Test-Layout" to "Test-WebTest"


2] Parent Label (e.g. Proj-, Hotlist-, etc...): Test-

3] Description of Label: "Blink web test"
It was "Layout test"

4] Please specify what triage practices will be followed for the label
(i.e. what team will do it and how frequently).

Component owners should triage issues.


*** Request to update "Layout Test Failure" template

Name: "Layout Test Failure" -> "Web Test Failure"

Summary "Layout Test [path/relative/to/LayoutTests/dir] (fails|is flaky) on [platform]"
  -> "Web Test [path/relative/to/LayoutTests/dir] (fails|is flaky) on [platform]"

Description: "The following layout test(s) is (failing|flaky) on [platform]: [list one or more tests] Caused by [full url to WebKit changeset]."
  -> "The following web test(s) is (failing|flaky) on [platform]: [list one or more tests] Caused by [full url to Chromium changeset]."

Labels: "Test-Layout" -> "Test-WebTest"

 
Status: Fixed (was: Untriaged)
This request has been approved, and the changes have been made. Closing bug. Please re-open if you encounter any issues. 
enegiar@, How to request updating "Layout Test Failure" template?
https://bugs.chromium.org/p/chromium/templates/detail?template=Layout+Test+Failure

Status: Untriaged (was: Fixed)
Reopen because "update "Layout Test Failure" template" part is not resolved.

Hi Kent,

Apologies for the trouble. It seems like it isn't possible to directly edit a template, so I deleted the "Layout Test Failure" template and created a new one for Web Tests with all the details you specified.

https://bugs.chromium.org/p/chromium/templates/detail?saved=1&template=Web%20Test%20Failure&ts=1545219136

Marking as fixed once again. Please do re-open if you encounter any other issues. 
Status: Fixed (was: Untriaged)
Cc: enegiar@chromium.org
Status: Untriaged (was: Fixed)
Thanks.  However there is one error in the Description field.

"[list one or more tests] Caused by [full url to WebKit changeset]."

should be removed.
Also, would you add some linebreaks like below please?

-------------------------------------
The following web test(s) is (failing|flaky) on [platform]:

[list one or more tests]

Caused by [full url to Chromium changeset].
--------------------------------------


Status: Fixed (was: Untriaged)
Done. Thanks for the good catch. Please re-open if you are still encountering any issues. 
Status: Untriaged (was: Fixed)
Leading and trailing "--------------------------------------" are unnecessary.

Status: Fixed (was: Untriaged)

Sign in to add a comment