New issue
Advanced search Search tips

Issue 914150 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

git cl format fails on repos not associated with Gerrit or Rietveld.

Reported by br...@amazon.com, Dec 11

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/70.0.3538.110 Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce the problem:
1. In a subdirectory containing a private repository (not managed by Gerrit or Rietveld), run `git cl format`
2. Get an AssertionError similar to:

src/third_party/depot_tools/git_cl.py", line 1164, in _load_codereview_impl
    assert codereview in _CODEREVIEW_IMPLEMENTATIONS

What is the expected behavior?
Code is formatted.

What went wrong?
Commit a185e2e3c83d805d3306a3f1fe9258ae2e75f231 removed the Rietveld code review
implementation, albeit hasn't expunged all references to Rietveld.  This leads
to an assertion error when running |git cl format| on a non-Gerrit change.
There appears to have been a recent attempt to articulate this error better in
a185e2e3c83d805d3306a3f1fe9258ae2e75f231, albeit not fix the underlying issue.
This change addresses the immediate issue by defaulting the code review
implementation to Gerrit rather than Reitveld.

Links to Mentioned Commits:

* https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a185e2e3c83d805d3306a3f1fe9258ae2e75f231%5E%21/
* https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/d87b09662ee8a8b50b2dd36630e9a9c4df562d1c%5E%21/#F0

Did this work before? N/A 

Chrome version: 70.0.3538.110  Channel: n/a
OS Version: 
Flash Version: 

I'll post a CL shortly.
 
Components: -Platform>DevTools Infra
Components: -Infra Infra>SDK
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET TE-NeedsTriageHelp
Thanks for filing the issue.

This issue is out of scope of triaging at TE end as this issue is related to Infra>SDK. Hence adding 'TE-NeedsTriageHelp' label and requesting the 'Infra>SDK' team to look into the issue and help in further triaging.

Thanks..!
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/cfc9712bc80a9807370a21a7274d8f24d6483cc7

commit cfc9712bc80a9807370a21a7274d8f24d6483cc7
Author: Bryce Thomas <bryct@amazon.com>
Date: Thu Dec 13 20:21:47 2018

Fix git cl format following removal of Rietveld.

Commit a185e2e3c83d805d3306a3f1fe9258ae2e75f231 removed the Rietveld code review
implementation, albeit hasn't expunged all references to Rietveld.  This leads
to an assertion error when running |git cl format| on a non-Gerrit change.
There appears to have been a recent attempt to articulate this error better in
a185e2e3c83d805d3306a3f1fe9258ae2e75f231, albeit not fix the underlying issue.
This change addresses the immediate issue by defaulting the code review
implementation to Gerrit rather than Reitveld.

R=joenotcharles@google.com, tandrii@chromium.org

Bug: 914150
Change-Id: I64d33e5a172cc43339ec417f7f0a7820e0337772
Reviewed-on: https://chromium-review.googlesource.com/c/1372928
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bryce Thomas <bryct@amazon.com>

[modify] https://crrev.com/cfc9712bc80a9807370a21a7274d8f24d6483cc7/tests/git_cl_test.py
[modify] https://crrev.com/cfc9712bc80a9807370a21a7274d8f24d6483cc7/git_cl.py

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154189135ef9d8a170c2091d1a5194155666caab

commit 154189135ef9d8a170c2091d1a5194155666caab
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Dec 14 00:22:01 2018

Roll src/third_party/depot_tools f423e051f343..cfc9712bc80a (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f423e051f343..cfc9712bc80a


git log f423e051f343..cfc9712bc80a --date=short --no-merges --format='%ad %ae %s'
2018-12-13 bryct@amazon.com Fix git cl format following removal of Rietveld.


Created with:
  gclient setdep -r src/third_party/depot_tools@cfc9712bc80a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:914150
TBR=agable@chromium.org

Change-Id: Ife467339838320f06e482a3b0c9c2e2f50898dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1376931
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616521}
[modify] https://crrev.com/154189135ef9d8a170c2091d1a5194155666caab/DEPS

Sign in to add a comment