New issue
Advanced search Search tips

Issue 914147 link

Starred by 1 user
Status: Assigned
Owner:
sammiequon@chromium.org
Cc:
omrilio@chromium.org
x...@chromium.org
afakhry@chromium.org
zork@chromium.org
minch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tracking bug for refactoring overview code.

Project Member Reported by sammiequon@chromium.org, Dec 11 
Overview mode code has built up quite a bit of technical debt over time, making it tough for developers to add new features to it. We should set some time to do some cleanup over the next milestone or two.

This bug will be a general tracker for related work.

Some ideas:
1) Rename instances of window_selector -> overview.
2) Split window_selector_unittest into different files (eg. overview_utils_test, window_selector_item_unittest). It's almost 5k lines long.
3) Introduce test api and maybe test utils to help do 2).
4) Combine window_selector and window_selector_controller? There does not seem to be a reason to keep them separate and forces us to use DeleteSoons and similar.
5) Extract some inline classes into their own files (eg. CaptionContainerView).

Please add more ideas you may have run into!

Comment 1 by afakhry@chromium.org, Dec 15

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f

commit ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Dec 18 19:49:58 2018

overview: Moves CaptionContainerView to its own file.

Its a pretty big class by itself. This cl only handles moving for now.
We'd like to move some tests from window_selector_unittest.cc to
window_selector_item_unittest and caption_container_view_unittest as
a followup. It will also be useful when we try to normalize the ui
for alt tab and overview.

Test: manual, trybots
Bug: 914147
Change-Id: I39717a2f1e6da7497fe21fc4cb1ee2324398d191
Reviewed-on: https://chromium-review.googlesource.com/c/1378243
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617595}
[modify] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/BUILD.gn
[add] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/caption_container_view.cc
[add] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/caption_container_view.h
[add] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/overview_constants.h
[modify] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/ae1c13aee1d894b7cc5640d1a56fa4c9f972a70f/ash/wm/overview/window_selector_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f

commit acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Jan 03 23:12:06 2019

overview: Introduce ScopedTransformOverviewWindowTest.

This cl:
1) Moves a bunch of tests from WindowSelectorTest to new
ScopedTransformOverviewWindowTest file.
2) Moves some static class constants to a newly introduced overview
constants file.

Test: ash_unittests ScopedTransformOverviewWindowTest*
Bug: 914147
Change-Id: I1c81533a0d0cb245c05ce4a4d288b574c0fc1784
Reviewed-on: https://chromium-review.googlesource.com/c/1394324
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619799}
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/BUILD.gn
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/drop_target_view.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/drop_target_view.h
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/overview_constants.h
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/scoped_transform_overview_window.h
[add] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/scoped_transform_overview_window_unittest.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/window_grid.h
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/window_selector_controller.h
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/acbdf928ab6cc987b74675c787dd6c1d5e0f6a7f/ash/wm/tablet_mode/tablet_mode_browser_window_drag_delegate.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4406472eab212408729a2ac4a6358529b34a87a

commit c4406472eab212408729a2ac4a6358529b34a87a
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jan 16 01:44:55 2019

overview: Removes text selector.

This is not used much in its current form according to UMA stats. May be
readded in the future.

The text selector used to handle key events, so make window selector a
event handler to handle the key events now.

The text selector used to also grab focus on entering overview, a new
|overview_focus_window_| does that now. We need that because accessiblity
needs a focused window to work, and we cannot use one of the transformed
windows or else activation will not work. I'll look into perhaps focusing
the tab highlight window in a later patch.

Test: manual
Bug: 907316, 914147
Change-Id: I7d1e292b440edd4ec1c724297b10d9307041c96c
Reviewed-on: https://chromium-review.googlesource.com/c/1391738
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622995}
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/ash_strings.grd
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/9cd665ec7aad53bd72476bb3bde8ed8eb78b9da9/ash/resources/vector_icons/overview_text_filter_search.icon
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_grid.h
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector.h
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa565d9a9d1b5acaf75e6819978198161114a80

commit 4fa565d9a9d1b5acaf75e6819978198161114a80
Author: Sammie Quon <sammiequon@chromium.org>
Date: Wed Jan 16 02:22:29 2019

Revert "overview: Removes text selector."

This reverts commit c4406472eab212408729a2ac4a6358529b34a87a.

Reason for revert: Did not mean to land without CQ

Original change's description:
> overview: Removes text selector.
> 
> This is not used much in its current form according to UMA stats. May be
> readded in the future.
> 
> The text selector used to handle key events, so make window selector a
> event handler to handle the key events now.
> 
> The text selector used to also grab focus on entering overview, a new
> |overview_focus_window_| does that now. We need that because accessiblity
> needs a focused window to work, and we cannot use one of the transformed
> windows or else activation will not work. I'll look into perhaps focusing
> the tab highlight window in a later patch.
> 
> Test: manual
> Bug: 907316, 914147
> Change-Id: I7d1e292b440edd4ec1c724297b10d9307041c96c
> Reviewed-on: https://chromium-review.googlesource.com/c/1391738
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622995}

TBR=oshima@chromium.org,afakhry@chromium.org,sammiequon@chromium.org

Change-Id: If1fc415fe51084e5caf0b7f68b50db34c9e4c876
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 907316, 914147
Reviewed-on: https://chromium-review.googlesource.com/c/1414011
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623048}
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/ash_strings.grd
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/resources/vector_icons/overview_text_filter_search.icon
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_grid.h
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector.h
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce9898d72e8892db1303dd0f774fc944f05fcb5

commit 8ce9898d72e8892db1303dd0f774fc944f05fcb5
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jan 16 04:36:44 2019

Reland "overview: Removes text selector."

This is a reland of c4406472eab212408729a2ac4a6358529b34a87a

Original change's description:
> overview: Removes text selector.
>
> This is not used much in its current form according to UMA stats. May be
> readded in the future.
>
> The text selector used to handle key events, so make window selector a
> event handler to handle the key events now.
>
> The text selector used to also grab focus on entering overview, a new
> |overview_focus_window_| does that now. We need that because accessiblity
> needs a focused window to work, and we cannot use one of the transformed
> windows or else activation will not work. I'll look into perhaps focusing
> the tab highlight window in a later patch.
>
> Test: manual
> Bug: 907316, 914147
> Change-Id: I7d1e292b440edd4ec1c724297b10d9307041c96c
> Reviewed-on: https://chromium-review.googlesource.com/c/1391738
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622995}

TBR=oshima@chromium.org

Bug: 907316, 914147
Change-Id: I7f55cc0ea6ca70ed02fbf78c64c190ffb2fef667
Reviewed-on: https://chromium-review.googlesource.com/c/1414430
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623106}
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/ash_strings.grd
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/7ab8a0d8db39581d6320ccacf990da413a9a2f45/ash/resources/vector_icons/overview_text_filter_search.icon
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_grid.h
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector.h
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/476910bb8551aab130b36033a5cc1f42dd97e50f

commit 476910bb8551aab130b36033a5cc1f42dd97e50f
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jan 16 18:24:01 2019

wm: Moves splitview indicators test code to its own file.

Test: ash_unittests SplitViewDragIndicators.*
Bug: 914147
Change-Id: I60d0d65a5c6fc2ef7d4344a99c85c443b68984a0
Reviewed-on: https://chromium-review.googlesource.com/c/1409919
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623300}
[modify] https://crrev.com/476910bb8551aab130b36033a5cc1f42dd97e50f/ash/BUILD.gn
[modify] https://crrev.com/476910bb8551aab130b36033a5cc1f42dd97e50f/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/476910bb8551aab130b36033a5cc1f42dd97e50f/ash/wm/splitview/split_view_drag_indicators.h
[add] https://crrev.com/476910bb8551aab130b36033a5cc1f42dd97e50f/ash/wm/splitview/split_view_drag_indicators_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db4a6c8c4a327e8508d705ba7db10e3218bf113

commit 2db4a6c8c4a327e8508d705ba7db10e3218bf113
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Jan 18 00:46:29 2019

overview: Refactor window_selector_unittest a bit.

1. Remove calls to CreateWindow and CreateWindowWidget and use the
AshTestBase versions.
2. Remove windows bounds if not needed.
3. Create some helper functions for reused codes.
4. Remove some unused headers.
5. Use GetEventGenerator() instead of creating new ones.

Test: ash_unittests WindowSelectorController*
Bug: 914147
Change-Id: I1ed8332bd851dd8e606e0b17d5197318b9481757
Reviewed-on: https://chromium-review.googlesource.com/c/1416557
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623932}
[modify] https://crrev.com/2db4a6c8c4a327e8508d705ba7db10e3218bf113/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/2db4a6c8c4a327e8508d705ba7db10e3218bf113/ash/wm/overview/window_selector_controller_unittest.cc
[modify] https://crrev.com/2db4a6c8c4a327e8508d705ba7db10e3218bf113/ash/wm/overview/window_selector_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Today (12 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64eca96f5a2f48ff47a28d38762dc5d76f02baa3

commit 64eca96f5a2f48ff47a28d38762dc5d76f02baa3
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Jan 22 18:24:05 2019

cros: Rename window_selectorXX to overviewXX.

Renames window_selector.cc -> overview_session.cc as overview.cc
sounded strange.

Renamed so files scoped_xx_overview_yy to scoped_overview_xx_yy to make
them match.

Test: ash_unittests
Bug: 914147
Change-Id: Ibc02f88d1ba1b3031bf787b59cc67eb01bf0daa3
Reviewed-on: https://chromium-review.googlesource.com/c/1419133
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624842}
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/BUILD.gn
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/app_list/app_list_controller_impl.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/app_list/home_launcher_gesture_handler.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/frame/non_client_frame_view_ash.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/frame/non_client_frame_view_ash.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/magnifier/docked_magnifier_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/magnifier/docked_magnifier_controller_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/session/session_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/session/session_controller_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/shell.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/shell.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/shell_observer.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/shell_test_api.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/system/accessibility/dictation_button_tray_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/gestures/overview_gesture_handler.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/gestures/overview_gesture_handler_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/immersive_gesture_drag_handler_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/caption_container_view.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/cleanup_animation_observer.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/cleanup_animation_observer.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/cleanup_animation_observer_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_constants.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_controller.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_controller.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_controller_unittest.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_delegate.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_grid.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_grid.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_item.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_item.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_session.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_session.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_session_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/overview_window_drag_controller.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/scoped_overview_hide_windows.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/scoped_overview_hide_windows.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/scoped_overview_transform_window.cc
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/scoped_overview_transform_window.h
[rename] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/scoped_overview_transform_window_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/start_animation_observer.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/start_animation_observer.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/overview/start_animation_observer_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/splitview/split_view_drag_indicators_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_app_window_drag_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_browser_window_drag_delegate.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_window_manager.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_window_manager.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/window_finder.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/window_finder_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/wm_shadow_controller_delegate.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/ash/wm/workspace_controller.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/chrome/browser/devtools/protocol/DEPS
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/chrome/browser/devtools/protocol/window_manager_handler.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/64eca96f5a2f48ff47a28d38762dc5d76f02baa3/components/exo/client_controlled_shell_surface_unittest.cc
►

Sign in to add a comment