New issue
Advanced search Search tips

Issue 914122 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 865565



Sign in to add a comment

Implement PortalActivateEvent/adoptPredecessor

Project Member Reported by jbroman@chromium.org, Dec 11

Issue description

We need to allow a portal, on activation, to adopt the predecessor (host) browsing context and place it in a <portal> element.

See:
https://wicg.github.io/portals/#dom-portalactivateevent-adoptpredecessor
 
Blocking: 865565
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89a74188918de7ea8988200c1b403619e5d843e4

commit 89a74188918de7ea8988200c1b403619e5d843e4
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jan 10 19:33:22 2019

Portals: Add support for PortalActivateEvent.

This event is dispatched on the portal Window when it is activated.

Bug: 914122
Change-Id: I4fa3117e1684c8f1d4ead95f62a7285978afaca2
Reviewed-on: https://chromium-review.googlesource.com/c/1396449
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621708}
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/content/browser/portal/portal.cc
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/content/common/frame.mojom
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/content/renderer/render_frame_impl.h
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/events/BUILD.gn
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/events/event_type_names.json5
[add] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/events/portal_activate_event.cc
[add] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/events/portal_activate_event.h
[add] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/events/portal_activate_event.idl
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[add] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/web_tests/external/wpt/portals/portal-activate-event.html
[add] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/web_tests/external/wpt/portals/resources/portal-activate-event-portal.html
[add] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/web_tests/external/wpt/portals/resources/portal-activate-event-window.html
[modify] https://crrev.com/89a74188918de7ea8988200c1b403619e5d843e4/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d7040bd639a2cec4530c68cc1a161d8629b0a0f

commit 9d7040bd639a2cec4530c68cc1a161d8629b0a0f
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Jan 16 23:28:56 2019

Portals: Add a WindowEventHandler to the PortalActivateEvent.

Bug: 914122
Change-Id: Ie1817a21216d86f59a708accea43e1d1ef316d6c
Reviewed-on: https://chromium-review.googlesource.com/c/1412794
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623445}
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/renderer/core/frame/window_event_handlers.h
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/renderer/core/frame/window_event_handlers.idl
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/renderer/core/html/html_attribute_names.json5
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/renderer/core/html/html_body_element.cc
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/renderer/core/html/html_frame_set_element.cc
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/external/wpt/portals/portal-activate-event.html
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/external/wpt/portals/resources/portal-activate-event-portal.html
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/external/wpt/portals/resources/portal-activate-event-window.html
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/9d7040bd639a2cec4530c68cc1a161d8629b0a0f/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Sign in to add a comment