New issue
Advanced search Search tips

Issue 914117 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 865565



Sign in to add a comment

Implement PortalHost exposure

Project Member Reported by jbroman@chromium.org, Dec 11

Issue description

This allows a document to know when it is embedded in a portal context, by reading window.portalHost.

See:
https://wicg.github.io/portals/#portalhost-exposed
https://wicg.github.io/portals/#dom-window-portalhost
 
Blocking: 865565
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4

commit e0a4b3e9655fccbee0cfa708216dd0a3d77941a4
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Jan 03 21:19:58 2019

Portals: Add window.portalHost

Adds IDL files for PortalHost and window.portalHost, and has a simple
layout test for window.portalHost.

Bug: 914117
Change-Id: Iccaae8992e7cf2794a26e171cebffc94deca8e1d
Reviewed-on: https://chromium-review.googlesource.com/c/1393438
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619757}
[modify] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/html/BUILD.gn
[add] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/html/portal/dom_window_portal_host.cc
[add] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/html/portal/dom_window_portal_host.h
[add] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/html/portal/portal_host.h
[add] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/html/portal/portal_host.idl
[add] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/renderer/core/html/portal/window_portal_host.idl
[add] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/web_tests/external/wpt/portals/portals-host-null.html
[modify] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[delete] https://crrev.com/b1dd96d950ca1a53bb7e8a499a2d8882ed2c82c2/third_party/blink/web_tests/virtual/user-activation-v2/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[delete] https://crrev.com/b1dd96d950ca1a53bb7e8a499a2d8882ed2c82c2/third_party/blink/web_tests/virtual/user-activation-v2/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/e0a4b3e9655fccbee0cfa708216dd0a3d77941a4/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d4738420905a6b28407a8282512d8307d413780

commit 9d4738420905a6b28407a8282512d8307d413780
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Jan 18 22:16:41 2019

Portals: Expose portalHost to portal's browsing context

window.portalHost returns a PortalHost to script running inside the main
frame within a portal.

Bug: 914117
Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1
Reviewed-on: https://chromium-review.googlesource.com/c/1399569
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624316}
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/browser/renderer_host/render_view_host_delegate.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/browser/renderer_host/render_view_host_delegate.h
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/common/renderer.mojom
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/content/renderer/render_view_impl.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/events/event_target_names.json5
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/html/BUILD.gn
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/html/portal/dom_window_portal_host.cc
[add] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/html/portal/portal_host.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/html/portal/portal_host.h
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/renderer/core/page/page.h
[add] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/web_tests/external/wpt/portals/portals-host-exposure.sub.html
[add] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/web_tests/external/wpt/portals/resources/portal-forward-with-broadcast.sub.html
[add] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/web_tests/external/wpt/portals/resources/portal-host-cross-origin-navigate.sub.html
[add] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/web_tests/external/wpt/portals/resources/portal-host-cross-origin.sub.html
[add] https://crrev.com/9d4738420905a6b28407a8282512d8307d413780/third_party/blink/web_tests/external/wpt/portals/resources/portal-host.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef

commit 8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Jan 19 01:45:42 2019

Revert "Portals: Expose portalHost to portal's browsing context"

This reverts commit 9d4738420905a6b28407a8282512d8307d413780.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 624316 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWQ0NzM4NDIwOTA1YTZiMjg0MDdhODI4MjUxMmQ4MzA3ZDQxMzc4MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29014

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: external/wpt/portals/portals-host-exposure.sub.html

Original change's description:
> Portals: Expose portalHost to portal's browsing context
> 
> window.portalHost returns a PortalHost to script running inside the main
> frame within a portal.
> 
> Bug: 914117
> Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1
> Reviewed-on: https://chromium-review.googlesource.com/c/1399569
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624316}

Change-Id: I38d4e208daafc8381495a4249c02928757bbdfc8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914117,  923610 
Reviewed-on: https://chromium-review.googlesource.com/c/1423660
Cr-Commit-Position: refs/heads/master@{#624405}
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/browser/renderer_host/render_view_host_delegate.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/browser/renderer_host/render_view_host_delegate.h
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/common/renderer.mojom
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/events/event_target_names.json5
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/html/BUILD.gn
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/html/portal/dom_window_portal_host.cc
[delete] https://crrev.com/d7e08558e23d5cdd19f236f3d6530f21b7fd8c33/third_party/blink/renderer/core/html/portal/portal_host.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/html/portal/portal_host.h
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef/third_party/blink/renderer/core/page/page.h
[delete] https://crrev.com/d7e08558e23d5cdd19f236f3d6530f21b7fd8c33/third_party/blink/web_tests/external/wpt/portals/portals-host-exposure.sub.html
[delete] https://crrev.com/d7e08558e23d5cdd19f236f3d6530f21b7fd8c33/third_party/blink/web_tests/external/wpt/portals/resources/portal-forward-with-broadcast.sub.html
[delete] https://crrev.com/d7e08558e23d5cdd19f236f3d6530f21b7fd8c33/third_party/blink/web_tests/external/wpt/portals/resources/portal-host-cross-origin-navigate.sub.html
[delete] https://crrev.com/d7e08558e23d5cdd19f236f3d6530f21b7fd8c33/third_party/blink/web_tests/external/wpt/portals/resources/portal-host-cross-origin.sub.html
[delete] https://crrev.com/d7e08558e23d5cdd19f236f3d6530f21b7fd8c33/third_party/blink/web_tests/external/wpt/portals/resources/portal-host.html

Sign in to add a comment