New issue
Advanced search Search tips

Issue 914099 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

BrowserAddedForProfileObserver improvements

Project Member Reported by rogerta@chromium.org, Dec 11

Issue description

The BrowserAddedForProfileObserver class implemented in //chrome/browser/profiles/profile_window.cc|h is used to run a callback when a browser window is opened for a given profile.  There are two possible improvements to this class:

1/ Change the type of the |callback| ctor argument from ProfileManager::CreateCallback to OnceCallback since it will only be called once.

2/ BrowserAddedForProfileObserver deletes itself after performing its function.  Howeever, if the class is not properly used it may leak.  That is, if a browser window is never opened for the given profile, the callback is never invoked and the object does not delete itself.

 
Owner: droger@chromium.org
Status: Assigned (was: Untriaged)
David: Adding this to your queue of bugs if you ever get to it.

Sign in to add a comment