New issue
Advanced search Search tips

Issue 914084 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

blink_perf.dom/custom-element-default-style.html failing on chromium.perf/android-nexus5x-perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 11

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

blink_perf.dom/custom-element-default-style.html failing on chromium.perf/android-nexus5x-perf

Builders failed on: 
- android-nexus5x-perf: 
  https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android-nexus5x-perf


 
Cc: tkent@chromium.org hayato@chromium.org
Components: Speed>Benchmarks>Waterfall
Cc: rakina@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3179adc43b421326b78059cc2ea0eb7a952f16bb

commit 3179adc43b421326b78059cc2ea0eb7a952f16bb
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Dec 12 01:35:01 2018

Disable blink_perf.dom custom element default style story

TBR=crouleau@chromium.org
CC=hayato@chromium.org,tkent@chromium.org

Bug:  914084 
Change-Id: I42a62fdb5bb6b7f74291272b4c3d1fc14bfbdbfa
Reviewed-on: https://chromium-review.googlesource.com/c/1372721
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615748}
[modify] https://crrev.com/3179adc43b421326b78059cc2ea0eb7a952f16bb/tools/perf/expectations.config

Owner: rakina@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/120a86e8140000

Constructable Stylesheets with replace methods by rakina@chromium.org
https://chromium.googlesource.com/chromium/src/+/5aeb932e04f7f94225f5eb804967f3985ed3de9d
Failure rate: 0 → 1 (+1)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54516f6cd34b1939b431c5fe9807e27dba3f3b3

commit d54516f6cd34b1939b431c5fe9807e27dba3f3b3
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Dec 12 10:19:59 2018

Update perf test for CE def style to use CSSStyleSheet constructor

Constructor for CSSStyleSheets has changed in a recent CL, so this test
is failing.

TBR=crouleau@chromium.org

Bug:  914084 
Change-Id: Icbf34425f9141bdd581a0c2ab9b568aaf058a358
Reviewed-on: https://chromium-review.googlesource.com/c/1373373
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615843}
[modify] https://crrev.com/d54516f6cd34b1939b431c5fe9807e27dba3f3b3/third_party/blink/perf_tests/dom/custom-element-default-style.html

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1862bd1de95f1bafca748650c68189d3821c11e

commit f1862bd1de95f1bafca748650c68189d3821c11e
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Dec 12 15:17:30 2018

Revert "Disable blink_perf.dom custom element default style story"

This reverts commit 3179adc43b421326b78059cc2ea0eb7a952f16bb.

Reason for revert: Problem was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1373373

Original change's description:
> Disable blink_perf.dom custom element default style story
> 
> TBR=crouleau@chromium.org
> CC=​hayato@chromium.org,tkent@chromium.org
> 
> Bug:  914084 
> Change-Id: I42a62fdb5bb6b7f74291272b4c3d1fc14bfbdbfa
> Reviewed-on: https://chromium-review.googlesource.com/c/1372721
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Commit-Queue: Charlie Andrews <charliea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615748}

TBR=tkent@chromium.org,charliea@chromium.org,crouleau@chromium.org

Change-Id: If7349256e7b5b4d8d84f3dff2cad7a813455c235
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  914084 
Reviewed-on: https://chromium-review.googlesource.com/c/1374091
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615889}
[modify] https://crrev.com/f1862bd1de95f1bafca748650c68189d3821c11e/tools/perf/expectations.config

Status: Fixed (was: Assigned)

Sign in to add a comment