[Autofill Sync] Record opt-in when user selects dropdown row |
||||||||
Issue descriptionThe Autofill dropdown is now showing a prompt to certain users with Sync Transport eligibility, offering to display cards from their account. Clicking this row should record their consent to see these cards.
,
Dec 12
,
Dec 12
Verified in Canary; requesting merge. This CL is a continuation of crbug.com/912303 and is necessary for the consent feature to function. Like that CL, it addresses UI and privacy/disclosure concerns for Sync Transport for Autofill Payments. Some of these concerns were raised quite recently thanks to feedback received during and after the DICE launch.
,
Dec 13
Whoops, adding correct label :)
,
Dec 13
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e70d3b062f831803ec48ca29813446d420ebe5d commit 6e70d3b062f831803ec48ca29813446d420ebe5d Author: Tommy Martino <tmartino@chromium.org> Date: Fri Dec 14 22:43:34 2018 [Merge 72][Autofill Sync] Trigger opt-in when dropdown row selected TBR=sebsg@chromium.org Bug: 914065 Change-Id: I9e030c1086428566692a6db7400f822018f653c0 Reviewed-on: https://chromium-review.googlesource.com/c/1372555 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615694}(cherry picked from commit 3f8aec345287f16a0123f6e29fe1e65abe580220) Reviewed-on: https://chromium-review.googlesource.com/c/1379038 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#373} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/6e70d3b062f831803ec48ca29813446d420ebe5d/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/6e70d3b062f831803ec48ca29813446d420ebe5d/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/6e70d3b062f831803ec48ca29813446d420ebe5d/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/6e70d3b062f831803ec48ca29813446d420ebe5d/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/6e70d3b062f831803ec48ca29813446d420ebe5d/components/autofill/core/browser/personal_data_manager.h
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e70d3b062f831803ec48ca29813446d420ebe5d Commit: 6e70d3b062f831803ec48ca29813446d420ebe5d Author: tmartino@chromium.org Commiter: tmartino@chromium.org Date: 2018-12-14 22:43:34 +0000 UTC [Merge 72][Autofill Sync] Trigger opt-in when dropdown row selected TBR=sebsg@chromium.org Bug: 914065 Change-Id: I9e030c1086428566692a6db7400f822018f653c0 Reviewed-on: https://chromium-review.googlesource.com/c/1372555 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615694}(cherry picked from commit 3f8aec345287f16a0123f6e29fe1e65abe580220) Reviewed-on: https://chromium-review.googlesource.com/c/1379038 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#373} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 11