Run an experiment to disable previews on reload |
||||||||||
Issue descriptionWe should run an experiment to disable previews on reload. This might require adding metrics to better understand how we would quantify the impact of this experiment. One way to quantify this might be to consider all implicit+explicit opt-outs as penalty on "non-painful" page loads. With the experiment, the opt-out count would decrease, and so the penalty would also decrease.
,
Dec 11
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a451e49ecd6598dd6480f8bc78a217d4ee47cb28 commit a451e49ecd6598dd6480f8bc78a217d4ee47cb28 Author: Ryan Sturm <ryansturm@chromium.org> Date: Wed Dec 12 20:28:02 2018 [previews] Prevent showing all previews on reloads This CL introduces a feature to prevent showing all preview types on all reloads. Historically, only Offline previews have been prevented on reload, but this notion should be cautiously extended to all Previews types. Bug: 914029 Change-Id: I8f3859a7f3ffd62b159cd064f117ed462faa1920 Reviewed-on: https://chromium-review.googlesource.com/c/1372541 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#616019} [modify] https://crrev.com/a451e49ecd6598dd6480f8bc78a217d4ee47cb28/components/previews/content/previews_decider_impl.cc [modify] https://crrev.com/a451e49ecd6598dd6480f8bc78a217d4ee47cb28/components/previews/content/previews_decider_impl_unittest.cc [modify] https://crrev.com/a451e49ecd6598dd6480f8bc78a217d4ee47cb28/components/previews/core/previews_features.cc [modify] https://crrev.com/a451e49ecd6598dd6480f8bc78a217d4ee47cb28/components/previews/core/previews_features.h
,
Dec 12
,
Dec 12
,
Dec 12
,
Dec 13
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13
How is the change listed at #3 looking in canary? How critical and safe is this change to merge to M72?
,
Dec 13
It's a pretty safe to merge CL since it's behind a finch.
,
Dec 13
Approving merge to M72 branch 3626 based on comment #9. Please merge ASAP. Thank you.
,
Dec 13
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4f245a031c95706b1a96c857da8411434d4c1f6 commit b4f245a031c95706b1a96c857da8411434d4c1f6 Author: Ryan Sturm <ryansturm@chromium.org> Date: Thu Dec 13 21:33:29 2018 [previews] Prevent showing all previews on reloads This CL introduces a feature to prevent showing all preview types on all reloads. Historically, only Offline previews have been prevented on reload, but this notion should be cautiously extended to all Previews types. Bug: 914029 Change-Id: I8f3859a7f3ffd62b159cd064f117ed462faa1920 Reviewed-on: https://chromium-review.googlesource.com/c/1372541 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616019}(cherry picked from commit a451e49ecd6598dd6480f8bc78a217d4ee47cb28) Reviewed-on: https://chromium-review.googlesource.com/c/1377107 Cr-Commit-Position: refs/branch-heads/3626@{#339} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b4f245a031c95706b1a96c857da8411434d4c1f6/components/previews/content/previews_decider_impl.cc [modify] https://crrev.com/b4f245a031c95706b1a96c857da8411434d4c1f6/components/previews/content/previews_decider_impl_unittest.cc [modify] https://crrev.com/b4f245a031c95706b1a96c857da8411434d4c1f6/components/previews/core/previews_features.cc [modify] https://crrev.com/b4f245a031c95706b1a96c857da8411434d4c1f6/components/previews/core/previews_features.h
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2787dcb3045aeb2fcd6484c69ddd3d23dea60c1a commit 2787dcb3045aeb2fcd6484c69ddd3d23dea60c1a Author: Ryan Sturm <ryansturm@chromium.org> Date: Mon Dec 17 22:09:22 2018 [previews] Adding a browser test for reload behavior The added browser test verifies that Previews are not triggered on a reload navigation. Bug: 914029 Change-Id: I3b0cc140d4cf175ae88c21a18ebf08ba4b9c4ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1374797 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#617247} [modify] https://crrev.com/2787dcb3045aeb2fcd6484c69ddd3d23dea60c1a/chrome/browser/previews/previews_lite_page_browsertest.cc
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4f245a031c95706b1a96c857da8411434d4c1f6 Commit: b4f245a031c95706b1a96c857da8411434d4c1f6 Author: ryansturm@chromium.org Commiter: tbansal@chromium.org Date: 2018-12-13 21:33:29 +0000 UTC [previews] Prevent showing all previews on reloads This CL introduces a feature to prevent showing all preview types on all reloads. Historically, only Offline previews have been prevented on reload, but this notion should be cautiously extended to all Previews types. Bug: 914029 Change-Id: I8f3859a7f3ffd62b159cd064f117ed462faa1920 Reviewed-on: https://chromium-review.googlesource.com/c/1372541 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616019}(cherry picked from commit a451e49ecd6598dd6480f8bc78a217d4ee47cb28) Reviewed-on: https://chromium-review.googlesource.com/c/1377107 Cr-Commit-Position: refs/branch-heads/3626@{#339} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 7
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tbansal@chromium.org
, Dec 11