New issue
Advanced search Search tips

Issue 914017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Window not always active when logging in

Project Member Reported by sky@chromium.org, Dec 11

Issue description

When running power.Idle tests the browser window is not active, which means no flashing caret. When logging in we should ensure a window is active.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dbdaebce5372443a810ad0c643ea17718607946

commit 7dbdaebce5372443a810ad0c643ea17718607946
Author: Scott Violet <sky@chromium.org>
Date: Tue Dec 11 22:39:02 2018

chromeos: ensure there is active window when unblocking

SessionController may block windows (such as browser windows) from becoming
active. When trasitioning from blocking to not-blocking we should ensure there
is an active window. To do otherwise means there may be no active window,
which is a state we try to ensure doesn't exist.

BUG= 914017 
TEST=covered by tests

Change-Id: I5d9392ea7706ea3603ecc6f68201f4931ebfe642
Reviewed-on: https://chromium-review.googlesource.com/c/1372408
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615700}
[modify] https://crrev.com/7dbdaebce5372443a810ad0c643ea17718607946/ash/session/session_controller.cc
[modify] https://crrev.com/7dbdaebce5372443a810ad0c643ea17718607946/ash/session/session_controller.h
[modify] https://crrev.com/7dbdaebce5372443a810ad0c643ea17718607946/ash/session/session_controller_unittest.cc
[modify] https://crrev.com/7dbdaebce5372443a810ad0c643ea17718607946/ash/shell.cc
[modify] https://crrev.com/7dbdaebce5372443a810ad0c643ea17718607946/ash/shell.h

Status: Fixed (was: Started)

Sign in to add a comment