New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 914007: Remove TCP FastOpen

Reported by mmenke@chromium.org, Dec 11 Project Member

Issue description

We never enabled it by default, and have no plans to, so we should just remove it.  QUIC also makes it less useful, and TLS 1.2 0-RTT session restore means it potentially mutates state.

It also leaks also leaks data between profiles, including (but not limited to) incognito profiles, since it relies on global system state.
 

Comment 1 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d

commit d629fd493eb2f4f52c6628f63d3d52e3c919dd5d
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Dec 12 05:41:59 2018

Remove TCP FastOpen support.

We never enabled it by default, and have no plans to, so we should just
remove it.  QUIC also makes it less useful, and TLS 1.2 0-RTT session
restore means it potentially mutates state.

It also leaks also leaks data between profiles, including (but not
limited to) incognito profiles, since it relies on global system state.

TBR=sergeyu@chromium.org

Bug:  914007 
Change-Id: Id9c333216661ee538cc6ce6e2b7f70b899393367
Reviewed-on: https://chromium-review.googlesource.com/c/1371938
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615819}
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/chrome/browser/about_flags.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/components/network_session_configurator/browser/network_session_configurator.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/components/network_session_configurator/common/network_switch_list.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/http/http_network_session.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/http/http_network_session.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/fuzzed_socket.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/sequenced_socket_data_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/socket_test_util.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/socket_test_util.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/socks_client_socket_pool_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/stream_socket.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_client_socket.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_client_socket.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_socket.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_socket_posix.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_socket_posix.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_socket_win.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/tcp_socket_win.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/transport_client_socket_pool.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/transport_client_socket_pool.h
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/socket/websocket_transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/net/websockets/websocket_basic_stream_adapters_test.cc
[modify] https://crrev.com/d629fd493eb2f4f52c6628f63d3d52e3c919dd5d/remoting/protocol/ssl_hmac_channel_authenticator.cc

Comment 2 by mmenke@chromium.org, Dec 12

Status: Fixed (was: Started)

Sign in to add a comment