Example: ``` ui::CalculateIdleState(idle_threshold, base::AdaptCallbackForRepeating(base::BindOnce( ``` In: https://chromium-review.googlesource.com/c/chromium/src/+/1351490/13/content/browser/idle/idle_manager.cc#41
Sam, are you working on this?
not at this exact time. took this as an AI from a code review. https://chromium-review.googlesource.com/c/chromium/src/+/1351490/13/content/browser/idle/idle_manager.cc#41
I started putting together a patch for this.
neat, thanks! cc-me on it so that i can early how you'd approach this?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e26b611998812c0d3bcc5d051f29b612dd242bb5 commit e26b611998812c0d3bcc5d051f29b612dd242bb5 Author: Reilly Grant <reillyg@chromium.org> Date: Thu Dec 20 17:32:58 2018 Make //ui/base/idle API synchronous This change updates the API in //base/ui/idle to be synchronous as all the platform-specific implementations call the provided callbacks synchronously. Bug: 913988 Change-Id: I0126e5a2fae947109b01c0493de4ea1c2412fd9a Reviewed-on: https://chromium-review.googlesource.com/c/1379183 Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618259} [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/chrome/browser/chromeos/policy/device_status_collector.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/chrome/browser/chromeos/policy/device_status_collector.h [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/chrome/browser/upgrade_detector/upgrade_detector.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/chrome/browser/upgrade_detector/upgrade_detector.h [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/extensions/browser/api/idle/idle_api.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/extensions/browser/api/idle/idle_api_unittest.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/extensions/browser/api/idle/idle_manager.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/extensions/browser/api/idle/idle_manager.h [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle.h [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle_chromeos.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle_fuchsia.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle_linux.cc [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle_mac.mm [modify] https://crrev.com/e26b611998812c0d3bcc5d051f29b612dd242bb5/ui/base/idle/idle_win.cc
Comment 1 by goto@chromium.org
, Dec 11