New issue
Advanced search Search tips

Issue 913983 link

Starred by 1 user
Status: Verified
Owner:
se...@chromium.org
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add metrics for the new dropdown option to see server cards.

Project Member Reported by se...@chromium.org, Dec 11 
We should record:

When the user had opted in so they could see their server cards
When the user did not see the server cards because they had not opted-in

For both of these, it should only be logged in WalletSyncTransport state and only if the user has server cards.

Comment 2 by se...@chromium.org, Dec 12

Labels: Merge-Request-72

Comment 3 by se...@chromium.org, Dec 12

Status: Verified (was: Started)

Comment 4 by abdulsyed@chromium.org, Dec 12

Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2833708395e85ccb383205f34204741c99fb9e80

commit 2833708395e85ccb383205f34204741c99fb9e80
Author: sebsg <sebsg@chromium.org>
Date: Wed Dec 12 20:38:17 2018

Merger-72 [AF] Add metrics for new dropdown option to see server cards.

TBR=sebsg@chromium.org

(cherry picked from commit e4c1ed27a1edd916546c5cbd81d9747c0b558e00)

Bug:  913983 
Change-Id: Ib2519bffbb11861ff525e4c3488623d4b574a1cb
Reviewed-on: https://chromium-review.googlesource.com/c/1372265
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615769}
Reviewed-on: https://chromium-review.googlesource.com/c/1374462
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#303}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/2833708395e85ccb383205f34204741c99fb9e80/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/2833708395e85ccb383205f34204741c99fb9e80/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/2833708395e85ccb383205f34204741c99fb9e80/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/2833708395e85ccb383205f34204741c99fb9e80/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/2833708395e85ccb383205f34204741c99fb9e80/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2833708395e85ccb383205f34204741c99fb9e80/tools/metrics/histograms/histograms.xml
Project Member

Comment 6 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/2833708395e85ccb383205f34204741c99fb9e80

Commit: 2833708395e85ccb383205f34204741c99fb9e80
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-12-12 20:38:17 +0000 UTC

Merger-72 [AF] Add metrics for new dropdown option to see server cards.

TBR=sebsg@chromium.org

(cherry picked from commit e4c1ed27a1edd916546c5cbd81d9747c0b558e00)

Bug:  913983 
Change-Id: Ib2519bffbb11861ff525e4c3488623d4b574a1cb
Reviewed-on: https://chromium-review.googlesource.com/c/1372265
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615769}
Reviewed-on: https://chromium-review.googlesource.com/c/1374462
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#303}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment