New issue
Advanced search Search tips

Issue 913980 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove ResourceScheduler::DeprecatedOnNavigate

Project Member Reported by tbansal@chromium.org, Dec 11

Issue description

This method won't be called when network servicification is enabled. The substitute logic would be for resource scheduler to register as an observer with NQE, and update params for the clients everytime there is a change in ECT.
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd05ee7ce74bcef9438775d777764cd7e3a23b1d

commit cd05ee7ce74bcef9438775d777764cd7e3a23b1d
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Dec 12 23:53:48 2018

ResourceScheduler: Update params when network quality changes.

Update network quality based params in resource scheduler every
time there is a change in network quality.

Also, remove NQE (network quality estimator) integration with the
deprecated method DeprecatedOnNavigate() since that method
is going away soon.

Note that this CL does not do a full cleanup which is going to
happen in subsequent CLs.

Change-Id: Id081e6a6aa872235301a6f3e0cc5ac7beb0e8584
Bug:  913980 
Reviewed-on: https://chromium-review.googlesource.com/c/1372055
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616112}
[modify] https://crrev.com/cd05ee7ce74bcef9438775d777764cd7e3a23b1d/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/cd05ee7ce74bcef9438775d777764cd7e3a23b1d/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/cd05ee7ce74bcef9438775d777764cd7e3a23b1d/services/network/resource_scheduler.cc
[modify] https://crrev.com/cd05ee7ce74bcef9438775d777764cd7e3a23b1d/services/network/resource_scheduler.h
[modify] https://crrev.com/cd05ee7ce74bcef9438775d777764cd7e3a23b1d/services/network/resource_scheduler_unittest.cc

Labels: -M-74 M-73
Status: Fixed (was: Assigned)

Sign in to add a comment