New issue
Advanced search Search tips

Issue 913977 link

Starred by 2 users
Status: Fixed
Owner:
tienmai@chromium.org
Closed: Dec 20
Cc:
rogerta@chromium.org
tienmai@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[GCPW] Differentiate between use of email pattern and hosted domain when validating emails

Project Member Reported by tienmai@google.com, Dec 11 
The registry key 'ep' (email pattern) used in GCPW is currently being passed to gaia signin page as 'hd' (hosted domain). We may want 'ep' to retain its meaning (that is a regex used to validate an email) so a different registry key should be added to GCPW to cover setting a hosted domain specifically.

Comment 1 by tienmai@chromium.org, Dec 14

Owner: tienmai@chromium.org
Status: Started (was: Untriaged)

Comment 2 by pastarmovj@chromium.org, Dec 14

Labels: Enterprise-Triaged
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42eeddf519f351a129ddad1237f92a73a6a6b9a6

commit 42eeddf519f351a129ddad1237f92a73a6a6b9a6
Author: Tien Mai <tienmai@chromium.org>
Date: Thu Dec 20 15:17:37 2018

Add verification of e-mails being signed in using GCPW.

- Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to
specify valid e-mail domains.
- Allow multiple valid e-mail domains
- Check Gaia signed in user has a valid e-mail / gaia id

Bug:  914366 ,  913977 
Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf
Reviewed-on: https://chromium-review.googlesource.com/c/1381726
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618215}
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/browser/ui/startup/credential_provider_signin_dialog_win.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/browser/ui/startup/credential_provider_signin_dialog_win_browsertest.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/common/gcp_strings.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/common/gcp_strings.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_credential_provider.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_credential_provider_idl.templ
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_resources.grd
[add] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ACCOUNT_IN_USE.png.sha1
[add] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ACCOUNT_LOCKED.png.sha1
[add] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_INVALID_EMAIL_DOMAIN.png.sha1
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/gcp_utils.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/os_user_manager.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/reauth_credential.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/reauth_credential.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/reauth_credential_unittests.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/reg_utils.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/gaiacp/reg_utils.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/test/fake_gls_run_helper.cc
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/test/fake_gls_run_helper.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/chrome/credential_provider/test/test_credential.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_p.c
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.h
[modify] https://crrev.com/42eeddf519f351a129ddad1237f92a73a6a6b9a6/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_p.c

Comment 4 by tienmai@chromium.org, Dec 20

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5126abd72308c9760a1f9622d061c33d58ecb6e

commit b5126abd72308c9760a1f9622d061c33d58ecb6e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Dec 20 23:13:01 2018

Revert "Add verification of e-mails being signed in using GCPW."

This reverts commit 42eeddf519f351a129ddad1237f92a73a6a6b9a6.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add verification of e-mails being signed in using GCPW.
> 
> - Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to
> specify valid e-mail domains.
> - Allow multiple valid e-mail domains
> - Check Gaia signed in user has a valid e-mail / gaia id
> 
> Bug:  914366 ,  913977 
> Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf
> Reviewed-on: https://chromium-review.googlesource.com/c/1381726
> Commit-Queue: Tien Mai <tienmai@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618215}

TBR=rogerta@chromium.org,thakis@chromium.org,tienmai@chromium.org

Change-Id: I82bfd838901dd7cd2730c4a0a1c8d0a4886b4c83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  914366 ,  913977 
Reviewed-on: https://chromium-review.googlesource.com/c/1387961
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618371}
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/browser/ui/startup/credential_provider_signin_dialog_win.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/browser/ui/startup/credential_provider_signin_dialog_win_browsertest.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/common/gcp_strings.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/common/gcp_strings.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/gaia_credential_provider.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/gaia_credential_provider_idl.templ
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/gaia_resources.grd
[delete] https://crrev.com/226244e4219e4d1047879025a30aa54ca5b9d590/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ACCOUNT_IN_USE.png.sha1
[delete] https://crrev.com/226244e4219e4d1047879025a30aa54ca5b9d590/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ACCOUNT_LOCKED.png.sha1
[delete] https://crrev.com/226244e4219e4d1047879025a30aa54ca5b9d590/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_INVALID_EMAIL_DOMAIN.png.sha1
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/gcp_utils.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/os_user_manager.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/reauth_credential.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/reauth_credential.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/reauth_credential_unittests.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/reg_utils.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/gaiacp/reg_utils.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/test/fake_gls_run_helper.cc
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/test/fake_gls_run_helper.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/chrome/credential_provider/test/test_credential.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_p.c
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.h
[modify] https://crrev.com/b5126abd72308c9760a1f9622d061c33d58ecb6e/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_p.c
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c88323269838c60dd910cc843949b46601e40f

commit 45c88323269838c60dd910cc843949b46601e40f
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Dec 20 23:35:19 2018

Reland "Add verification of e-mails being signed in using GCPW."

This reverts commit b5126abd72308c9760a1f9622d061c33d58ecb6e.

Reason for revert: Breaks build

Original change's description:
> Revert "Add verification of e-mails being signed in using GCPW."
> 
> This reverts commit 42eeddf519f351a129ddad1237f92a73a6a6b9a6.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Add verification of e-mails being signed in using GCPW.
> > 
> > - Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to
> > specify valid e-mail domains.
> > - Allow multiple valid e-mail domains
> > - Check Gaia signed in user has a valid e-mail / gaia id
> > 
> > Bug:  914366 ,  913977 
> > Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf
> > Reviewed-on: https://chromium-review.googlesource.com/c/1381726
> > Commit-Queue: Tien Mai <tienmai@chromium.org>
> > Reviewed-by: Roger Tawa <rogerta@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#618215}
> 
> TBR=rogerta@chromium.org,thakis@chromium.org,tienmai@chromium.org
> 
> Change-Id: I82bfd838901dd7cd2730c4a0a1c8d0a4886b4c83
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  914366 ,  913977 
> Reviewed-on: https://chromium-review.googlesource.com/c/1387961
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618371}

TBR=rogerta@chromium.org,thakis@chromium.org,lethalantidote@chromium.org,tienmai@chromium.org

Change-Id: I8888a63d3d14387a954b45cdbc306292ba97059c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  914366 ,  913977 
Reviewed-on: https://chromium-review.googlesource.com/c/1388028
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618374}
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/browser/ui/startup/credential_provider_signin_dialog_win.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/browser/ui/startup/credential_provider_signin_dialog_win_browsertest.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/common/gcp_strings.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/common/gcp_strings.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_credential_provider.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_credential_provider_idl.templ
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_resources.grd
[add] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ACCOUNT_IN_USE.png.sha1
[add] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ACCOUNT_LOCKED.png.sha1
[add] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_INVALID_EMAIL_DOMAIN.png.sha1
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/gcp_utils.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/os_user_manager.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/reauth_credential.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/reauth_credential.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/reauth_credential_unittests.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/reg_utils.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/gaiacp/reg_utils.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/test/fake_gls_run_helper.cc
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/test/fake_gls_run_helper.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/chrome/credential_provider/test/test_credential.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_p.c
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.h
[modify] https://crrev.com/45c88323269838c60dd910cc843949b46601e40f/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_p.c
►

Sign in to add a comment