New issue
Advanced search Search tips

Issue 913973 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Don't offer to see server cards if the feature to see them is enabled.

Project Member Reported by se...@chromium.org, Dec 11

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18871e0aeb788bb223feb1bcb26722e0151d4760

commit 18871e0aeb788bb223feb1bcb26722e0151d4760
Author: sebsg <sebsg@chromium.org>
Date: Wed Dec 12 22:05:04 2018

[AF] Don't offer to see server cards if feature to see them is enabled.

Bug:  913973 
Change-Id: I3081b3392135774f54745c7da60089328e64393b
Reviewed-on: https://chromium-review.googlesource.com/c/1371929
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616069}
[modify] https://crrev.com/18871e0aeb788bb223feb1bcb26722e0151d4760/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/18871e0aeb788bb223feb1bcb26722e0151d4760/components/autofill/core/browser/personal_data_manager_unittest.cc

Labels: Merge-Request-72
Should be the last one from me.
let's verify this in canary first. 
Summary: Don't offer to see server cards if the feature to see them is enabled. (was: Don't offer to see server cards if the feature to see the is enabled.)
Status: Verified (was: Started)
It works fine on Canary :)
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 13

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-72 Merge-Approved-72
Approved for M72 - Branch:3626
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 17

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/232c95f3b193de24085160d4a5097e749a978172

commit 232c95f3b193de24085160d4a5097e749a978172
Author: sebsg <sebsg@chromium.org>
Date: Mon Dec 17 14:56:19 2018

Merge72 [AF] Don't offer to see server cards if feature is enabled.

TBR=sebsg@chromium.org

(cherry picked from commit 18871e0aeb788bb223feb1bcb26722e0151d4760)

Bug:  913973 
Change-Id: I3081b3392135774f54745c7da60089328e64393b
Reviewed-on: https://chromium-review.googlesource.com/c/1371929
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616069}
Reviewed-on: https://chromium-review.googlesource.com/c/1379916
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#386}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/232c95f3b193de24085160d4a5097e749a978172/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/232c95f3b193de24085160d4a5097e749a978172/components/autofill/core/browser/personal_data_manager_unittest.cc

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/232c95f3b193de24085160d4a5097e749a978172

Commit: 232c95f3b193de24085160d4a5097e749a978172
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-12-17 14:56:19 +0000 UTC

Merge72 [AF] Don't offer to see server cards if feature is enabled.

TBR=sebsg@chromium.org

(cherry picked from commit 18871e0aeb788bb223feb1bcb26722e0151d4760)

Bug:  913973 
Change-Id: I3081b3392135774f54745c7da60089328e64393b
Reviewed-on: https://chromium-review.googlesource.com/c/1371929
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616069}
Reviewed-on: https://chromium-review.googlesource.com/c/1379916
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#386}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment