New issue
Advanced search Search tips

Issue 913968 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Divider in suggested-password dropdown seems to transparent

Project Member Reported by maxwalker@chromium.org, Dec 11

Issue description

Chrome Version: 73.0.3637.0 
OS: macOS

The divider in the suggested-password dropdown seems to transparent so that the content area shines through.
 
Divider.png
72.1 KB View Download
Cc: vasi...@chromium.org
Owner: tmartino@chromium.org
r615326 seems to be the culprit.
Could you let me know the flags and page you're using to test this?
https://rsolomakhin.github.io/autofill/

Right click on the password field and click "Suggest password". You need to be signed-in to Chromium.
Cc: nyerramilli@chromium.org tmartino@chromium.org rbasuvula@chromium.org
 Issue 916466  has been merged into this issue.
I don't see the Suggest Password option. Are there flags/settings that affect whether or not it appears?
Are you signed-in to Chrome and syncing passwords?
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d56c7995b20069d803d3a1f54f0323fe7d255ef

commit 5d56c7995b20069d803d3a1f54f0323fe7d255ef
Author: tmartino <tmartino@chromium.org>
Date: Thu Jan 10 16:24:23 2019

Fixing Password Generation transparency issue

This CL fixes a small issue where the divider between the content and
footer of the Password Generation popup is transparent on macOS. It
adds a call to set a white background behind the popup, which is
consistent with what we do in AutofillPopupViewNativeViews.

Bug:  913968 
Change-Id: I113477fd3b6bcd621540f83c476f51669d403453
Reviewed-on: https://chromium-review.googlesource.com/c/1403939
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621593}
[modify] https://crrev.com/5d56c7995b20069d803d3a1f54f0323fe7d255ef/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc

Status: Fixed (was: Assigned)
This should be fixed. Could one of Max or Vasilii please verify in tomorrow's Canary that everything looks the way they expect it?
Screen Shot 2019-01-11 at 11.17.09.png
22.7 KB View Download
Labels: TE-Verified-M73 TE-Verified-73.0.3668.0
Update:

Rechecked the above issue on  Mac(10.13.1, 10.13.6, 10.14.3) OS using latest Canary build #73.0.3668.0 and the issue is fixed. Kindly refer attached screen cast.

Thank you
Fixed Result.mov
1.1 MB View Download
Status: Verified (was: Fixed)

Sign in to add a comment