[Password Manager] Consider server predictions for password fields in SAVING mode |
|||||||||
Issue descriptionAs server predictions for password fields can be incomplete (no current password prediction on a change password form or no confirmation password prediction while the confirmation field is present), don't use the predictions in SAVING mode. At the moment, the client heuristics (|LocateSpecificPasswords|) is more reliable when user-typed values are available. When the server will be able to provide complete predictions, use them for more accurate saving (trust only server prediction or combine with the client heuristics). More details: https://docs.google.com/document/d/10bV_eHANUenmsLSKn67HvYvz8V-9mEgrf_BAUxqoH7Y/edit (sorry, Google internal)
,
Dec 21
This change fixes the core heuristics of the form parser. It affects on whether Chrome prompts to save a credential. The new code is well-tested.
,
Dec 21
The bug is marked as P3 or Feature. It should not be merged as M72 is in beta. Please contact the approriate milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 21
The priority wasn't correct.
,
Dec 21
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2
Pls apply appropriate OSs label.
,
Jan 3
,
Jan 3
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d3f64731cf3b09707d1ba6755588ec5d8a0168 commit a7d3f64731cf3b09707d1ba6755588ec5d8a0168 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Fri Jan 04 14:47:14 2019 [Merge-M72][Password Manager] Don't consider server predictions for password fields in SAVING mode As server predictions for password fields can be incomplete (no current password prediction on a change password form or no confirmation password prediction while the confirmation field is present), don't use the predictions in SAVING mode. At the moment, the client heuristics (|LocateSpecificPasswords|) is more reliable when user-typed values are available. When the server will be able to provide complete predictions, use them for more accurate saving (trust only server prediction or combine with the client heuristics). TBR=kolos@chromium.org (cherry picked from commit d1a1f83ac97db0128de76060c04f4c2c2f931ee9) Bug: 907910, 552420, 913965 Change-Id: I63eee5a6a8fceb3cef23bfd1a955c96ec44d0b7d Reviewed-on: https://chromium-review.googlesource.com/c/1371813 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617844} Reviewed-on: https://chromium-review.googlesource.com/c/1396027 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#560} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/a7d3f64731cf3b09707d1ba6755588ec5d8a0168/components/password_manager/core/browser/form_parsing/form_parser.cc [modify] https://crrev.com/a7d3f64731cf3b09707d1ba6755588ec5d8a0168/components/password_manager/core/browser/form_parsing/form_parser_unittest.cc
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d3f64731cf3b09707d1ba6755588ec5d8a0168 Commit: a7d3f64731cf3b09707d1ba6755588ec5d8a0168 Author: kolos@chromium.org Commiter: kolos@chromium.org Date: 2019-01-04 14:47:14 +0000 UTC [Merge-M72][Password Manager] Don't consider server predictions for password fields in SAVING mode As server predictions for password fields can be incomplete (no current password prediction on a change password form or no confirmation password prediction while the confirmation field is present), don't use the predictions in SAVING mode. At the moment, the client heuristics (|LocateSpecificPasswords|) is more reliable when user-typed values are available. When the server will be able to provide complete predictions, use them for more accurate saving (trust only server prediction or combine with the client heuristics). TBR=kolos@chromium.org (cherry picked from commit d1a1f83ac97db0128de76060c04f4c2c2f931ee9) Bug: 907910, 552420, 913965 Change-Id: I63eee5a6a8fceb3cef23bfd1a955c96ec44d0b7d Reviewed-on: https://chromium-review.googlesource.com/c/1371813 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617844} Reviewed-on: https://chromium-review.googlesource.com/c/1396027 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#560} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 19