This is to accumulate all CLs relating to Search for Copied Image feature.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd964bbc72f222ccdebc589f419865a288fee10a commit cd964bbc72f222ccdebc589f419865a288fee10a Author: Robbie Gibson <rkgibson@google.com> Date: Tue Dec 11 18:22:21 2018 [iOS] Add flag for Search for Copied Image feature Bug: 913958 Change-Id: Ib942171d8f94e7b37cb91cdebe52c5e02141917e Reviewed-on: https://chromium-review.googlesource.com/c/1371893 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615595} [modify] https://crrev.com/cd964bbc72f222ccdebc589f419865a288fee10a/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/cd964bbc72f222ccdebc589f419865a288fee10a/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/cd964bbc72f222ccdebc589f419865a288fee10a/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/cd964bbc72f222ccdebc589f419865a288fee10a/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/cd964bbc72f222ccdebc589f419865a288fee10a/ios/chrome/browser/ui/ui_feature_flags.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ad5d16b8665585bec05439d8b0a9273ac1a09b3 commit 1ad5d16b8665585bec05439d8b0a9273ac1a09b3 Author: Robbie Gibson <rkgibson@google.com> Date: Tue Jan 08 23:53:31 2019 [iOS] Add Search for Copied Image to search accelerator menu This CL adds the search for copied image option to the search accelerator menu, which allows the user to search for an image they have in their pasteboard. This also requires updating ClipboardRecentContent to provide images. Bug: 913958 Change-Id: I366c1cc987a7707922398b91c560bb451caa7d63 Reviewed-on: https://chromium-review.googlesource.com/c/1391668 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#620942} [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/BUILD.gn [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/DEPS [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_generic.cc [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_generic.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_impl_ios.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_impl_ios.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_ios.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_ios.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/fake_clipboard_recent_content.cc [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/components/open_from_clipboard/fake_clipboard_recent_content.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/app/strings/ios_strings.grd [add] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_TOOLS_MENU_SEARCH_COPIED_IMAGE.png.sha1 [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/search_engines/search_engines_util.cc [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/search_engines/search_engines_util.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/commands/browser_commands.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/image_util/BUILD.gn [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/image_util/image_util.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/image_util/image_util.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_item.h [modify] https://crrev.com/1ad5d16b8665585bec05439d8b0a9273ac1a09b3/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e13f2e6a9ce7ba8420d74491d62c6e74e60f362b commit e13f2e6a9ce7ba8420d74491d62c6e74e60f362b Author: Robbie Gibson <rkgibson@google.com> Date: Wed Jan 09 11:00:24 2019 Add non-functional match for copied image to omnibox zero suggest This CL adds a match to the omnibox zero suggest for an image copied to the user's clipboard. The match is currently non-functional; it appears but selecting it does nothing. This is because AutocompleteMatch requires future work to allow it to handle matches that have more than just a URL (image searching has post content as well). Bug: 913958 Change-Id: Ie9ffd9a4e10caed3208310cf9d5ae38388519f98 Reviewed-on: https://chromium-review.googlesource.com/c/1393365 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#621110} [modify] https://crrev.com/e13f2e6a9ce7ba8420d74491d62c6e74e60f362b/components/omnibox/browser/clipboard_url_provider.cc [modify] https://crrev.com/e13f2e6a9ce7ba8420d74491d62c6e74e60f362b/components/omnibox/browser/clipboard_url_provider.h [modify] https://crrev.com/e13f2e6a9ce7ba8420d74491d62c6e74e60f362b/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/e13f2e6a9ce7ba8420d74491d62c6e74e60f362b/components/omnibox_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c commit 80d732e3a2ba5237dad72deff3fe81cbee2dbb9c Author: Robbie Gibson <rkgibson@google.com> Date: Thu Jan 10 10:42:49 2019 [iOS] Separate flags for copied text/images in omnibox and elsewhere This CL separates the one "copied text behavior" flag into 3. One controls the copied text suggestion in the omnibox, one controls the copied image suggestion in the omnibox, and the last controls all copied content behavior elesewhere (omnibox long-press, search accelerator menu) Bug: 913958 Change-Id: I36ae3266ce03c657697777b9c43b0ba206bc677b Reviewed-on: https://chromium-review.googlesource.com/c/1402754 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#621534} [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/components/omnibox/browser/clipboard_url_provider.cc [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/components/omnibox/browser/clipboard_url_provider_unittest.cc [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/components/omnibox/browser/omnibox_field_trial.h [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/80d732e3a2ba5237dad72deff3fe81cbee2dbb9c/ios/chrome/browser/ui/ui_feature_flags.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dd58110f2adf3e296c0903dc53fbf7a111c04cd commit 7dd58110f2adf3e296c0903dc53fbf7a111c04cd Author: Robbie Gibson <rkgibson@google.com> Date: Tue Jan 15 10:41:09 2019 [iOS] Handle copied images in omnibox longpress This CL adds searching for a copied image as one of the options from a longpress on the omnibox. Before, there was "Visit Copied Link" and "Search Copied Text." Bug: 913958 Change-Id: I5f73dde2e5d31e1f98b664691f89413eb4b417d4 Reviewed-on: https://chromium-review.googlesource.com/c/1402810 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#622806} [modify] https://crrev.com/7dd58110f2adf3e296c0903dc53fbf7a111c04cd/ios/chrome/app/strings/ios_strings.grd [add] https://crrev.com/7dd58110f2adf3e296c0903dc53fbf7a111c04cd/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SEARCH_COPIED_IMAGE.png.sha1 [modify] https://crrev.com/7dd58110f2adf3e296c0903dc53fbf7a111c04cd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm [modify] https://crrev.com/7dd58110f2adf3e296c0903dc53fbf7a111c04cd/ios/chrome/browser/ui/omnibox/omnibox_coordinator.mm [modify] https://crrev.com/7dd58110f2adf3e296c0903dc53fbf7a111c04cd/ios/chrome/browser/ui/omnibox/omnibox_view_controller.h [modify] https://crrev.com/7dd58110f2adf3e296c0903dc53fbf7a111c04cd/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e74f7d6343cfde767e7329ea5ffadc22d3bae23 commit 3e74f7d6343cfde767e7329ea5ffadc22d3bae23 Author: Robbie Gibson <rkgibson@google.com> Date: Mon Jan 21 14:03:00 2019 Add new clipboard types for text and image searches This CL adds new autocomplete match types for text and image clipboard searches, as well as renaming the existing CLIPBOARD type to CLIPBOARD_URL. Bug: 913958 Change-Id: Iea3826fa7e09e84a791c6a1c997c6fbd53daa5bb Reviewed-on: https://chromium-review.googlesource.com/c/1409509 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#624576} [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/chrome/browser/android/omnibox/autocomplete_controller_android.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/chrome/browser/ui/app_list/search/omnibox_result.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/components/omnibox/browser/autocomplete_controller.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/components/omnibox/browser/autocomplete_match.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/components/omnibox/browser/autocomplete_match_type.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/components/omnibox/browser/autocomplete_match_type.h [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/components/omnibox/browser/clipboard_url_provider.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/components/omnibox/browser/omnibox_metrics_provider.cc [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/ios/chrome/browser/ui/omnibox/omnibox_util.mm [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_ios.mm [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/third_party/metrics_proto/README.chromium [modify] https://crrev.com/3e74f7d6343cfde767e7329ea5ffadc22d3bae23/third_party/metrics_proto/omnibox_event.proto
Comment 1 by bugdroid1@chromium.org
, Dec 11