New issue
Advanced search Search tips

Issue 913948 link

Starred by 1 user
Status: Fixed
Owner:
michaelludwig@google.com
Closed: Dec 12
Cc:
fmalita@chromium.org
bsalo...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline tests for Skia rectangle draw update

Project Member Reported by michaelludwig@google.com, Dec 11 
The following layout tests would fail after https://skia-review.googlesource.com/c/skia/+/173105 lands:

 media/video-layer-crash.html
 virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns.html
 virtual/gpu/fast/canvas/image-object-in-canvas.html
 virtual/gpu-rasterization/images/color-profile-background-image-cover.html
 virtual/gpu-rasterization/images/color-profile-background-image-repeat.html
 virtual/gpu-rasterization/images/color-profile-background-image-space.html
 virtual/gpu-rasterization/images/color-profile-border-image.html
 virtual/gpu-rasterization/images/color-profile-filter.html
 virtual/gpu-rasterization/images/color-profile-image-canvas-pattern.html
 virtual/gpu-rasterization/images/color-profile-image-canvas.html
 virtual/gpu-rasterization/images/color-profile-image-filter-all.html
 virtual/gpu-rasterization/images/color-profile-image-profile-match.html
 virtual/gpu-rasterization/images/color-profile-image.html
 virtual/gpu-rasterization/images/color-profile-mask-image-svg.html
 virtual/gpu-rasterization/images/color-profile-object.html
 virtual/gpu-rasterization/images/color-profile-svg-fill-text.html
 virtual/gpu-rasterization/images/color-profile-svg.html
 virtual/gpu-rasterization/images/cross-fade-background-size.html
 virtual/gpu-rasterization/images/exif-orientation-height-image-document.html
 virtual/gpu-rasterization/images/image-map-anchor-children.html
 virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile.html
 virtual/gpu-rasterization/images/sprite-no-bleed.html
 virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile.html
 virtual/video-surface-layer/media/video-layer-crash.html

Caused by Skia CL https://skia-review.googlesource.com/c/skia/+/173105

This CL overhauls how the GPU draws all rectangles, which means that there are very slight numerical differences in how texture coordinates are interpolated across the rectangles. This leads to the layout failures seen here, where scattered pixels differ by 1-2 only and are otherwise unnoticeable.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeb4f38b44a6858074fa93a5c6d55661b88d19ee

commit eeb4f38b44a6858074fa93a5c6d55661b88d19ee
Author: Michael Ludwig <michaelludwig@google.com>
Date: Tue Dec 11 16:02:47 2018

Suppress layout tests for Skia rectangle change

Bug:  913948 
Change-Id: I2712119f0ff48a56d1a8b994dc470e76b37250d2
Reviewed-on: https://chromium-review.googlesource.com/c/1371925
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615541}
[modify] https://crrev.com/eeb4f38b44a6858074fa93a5c6d55661b88d19ee/third_party/blink/web_tests/TestExpectations
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af466bceb087b5573cb84c68455a200d78657673

commit af466bceb087b5573cb84c68455a200d78657673
Author: Michael Ludwig <michaelludwig@google.com>
Date: Wed Dec 12 21:28:24 2018

Remove suppression

The rebaseline diffs are a little trickier to follow because many specific
expectations have been moved into a more generic family, either from
Mac and Windows versions to just Mac/Windows generic, or all the way to
a platform independent expectation image.

Bug:  913948 
Change-Id: Ifa1cfa5191587a0ece36c2ce06dc111db5f699fa
Reviewed-on: https://chromium-review.googlesource.com/c/1372221
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616048}
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/linux/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-mac10.10/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-mac10.10/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-mac10.11/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-mac10.12/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-mac10.12/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-retina/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/media/video-layer-crash-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/image-map-anchor-children-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/media/video-layer-crash-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/color-profile-image-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/platform/win/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/win/virtual/video-surface-layer/media/video-layer-crash-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/win7/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/platform/win7/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-object-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-svg-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[modify] https://crrev.com/af466bceb087b5573cb84c68455a200d78657673/third_party/blink/web_tests/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/third_party/blink/web_tests/virtual/video-surface-layer/media/video-layer-crash-expected.png

Comment 4 by michaelludwig@google.com, Dec 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment