New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913947 link

Starred by 3 users
Status: Available
Owner:
jkrcal@chromium.org
Cc:
feuunk@chromium.org
butter-team@google.com
se...@chromium.org
treib@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

Clean up dependency from PersonalDataManager to SyncService

Project Member Reported by feuunk@chromium.org, Dec 11 
Currently PersonalDataManager depends on OnSyncServiceInitialized() being called. However, we're currently calling this from the AutofillManager constructor, which is a strange place.

For crbug.com/913945, we're adding another odd call site. We should find a single good call site instead, and remove the other two.

Comment 1 by jkrcal@chromium.org, Dec 12

Labels: Pri-1 Type-Bug
Status: Available (was: Untriaged)
Triager's pass: 
 - Assigning Pri=1. Feel free to change prio. 
 - If the priority sticks, we should find an owner. Marc, Florian, Seb, any volunteers?

Comment 2 by jkrcal@chromium.org, Dec 14

Cc: treib@chromium.org se...@chromium.org feuunk@chromium.org
cc'ing you explicitly.

We should find an owner. Marc, Florian, Seb, any volunteers?

Comment 3 by jkrcal@chromium.org, Dec 17

Owner: jkrcal@chromium.org
It seems like this is causing flakiness in sync integration tests (Issue 915229).

There is a simple obvious fix/hack for that but still, I'm getting sick with the current situation and grabbing this bug.

Comment 4 by mamir@chromium.org, Jan 7 

jkrcal@ did you get a chance to apply the obvious fix you had in mind? ;-)

Comment 5 by jkrcal@google.com, Jan 8 

Yep, I've applied the obvious hack so integration tests are happy again.
Still, this does not mean that I can close the bug. I haven't started on a proper clean-up, yet.

Comment 6 by jkrcal@chromium.org, Yesterday (43 hours ago) 

Still, no progress on this front. I want to keep it as a P1, though.
►

Sign in to add a comment