New issue
Advanced search Search tips

Issue 913942 link

Starred by 1 user
Status: Assigned
Owner:
rdevlin....@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Check extensions/renderer for safety of v8 ToLocalChecked functions

Project Member Reported by delph...@chromium.org, Dec 11 
There are several cases of v8::Value::ToLocalChecked in extensions/renderer. These will kill the renderer process with CHECK failures if an exception occurred.

They should be verified to ensure this can never happen or they should handle the exception gracefully.

Two such cases in the comments of crrev.com/c/1353985
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19cdae86d6482445ed480eeb9af72b38d1e51c81

commit 19cdae86d6482445ed480eeb9af72b38d1e51c81
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Dec 11 16:03:51 2018

[cleanup] Fix many deprecated v8 calls in extensions/renderer

Replaces many deprecated uses of v8 functions Object::Get/Set,
Value::ToString, in extensions/renderer with versions that return
Maybe/MaybeLocals or by using casts if there are already
checks that ensure the cast will always succeed.

Bug: v8:7279, v8:7283, v8:8562, chromium:913942
Change-Id: I4aeec76251bd11dfc274156d8d00586e04e9a99e
Reviewed-on: https://chromium-review.googlesource.com/c/1353985
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615543}
[modify] https://crrev.com/19cdae86d6482445ed480eeb9af72b38d1e51c81/extensions/renderer/activity_log_converter_strategy_unittest.cc
[modify] https://crrev.com/19cdae86d6482445ed480eeb9af72b38d1e51c81/extensions/renderer/api_activity_logger.cc
[modify] https://crrev.com/19cdae86d6482445ed480eeb9af72b38d1e51c81/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/19cdae86d6482445ed480eeb9af72b38d1e51c81/extensions/renderer/module_system.cc
[modify] https://crrev.com/19cdae86d6482445ed480eeb9af72b38d1e51c81/extensions/renderer/module_system_test.cc
[modify] https://crrev.com/19cdae86d6482445ed480eeb9af72b38d1e51c81/extensions/renderer/v8_context_native_handler.cc
►

Sign in to add a comment