Since these methods are now const/static, it should be simple to move them out. For example IsCreditCardDeletable and IsKnownCard
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f17ed45c11b3e475cdb9f23c4119338a874f16f commit 7f17ed45c11b3e475cdb9f23c4119338a874f16f Author: sebsg <sebsg@chromium.org> Date: Mon Dec 17 23:55:37 2018 [AF] Move the IsDeletable... function from PDM to card/address classes. Bug: 913941 Change-Id: I89667e635b362cc33629d8d2a9873d70e881423d Reviewed-on: https://chromium-review.googlesource.com/c/1381138 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#617297} [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/autofill_data_model.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/autofill_data_model.h [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/autofill_data_model_unittest.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/autofill_profile.h [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/autofill_profile_unittest.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/7f17ed45c11b3e475cdb9f23c4119338a874f16f/components/autofill/core/common/autofill_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5cf076bcc56c80846a92373bdda2d907b9a3b6 commit 5c5cf076bcc56c80846a92373bdda2d907b9a3b6 Author: Tsuyoshi Horo <horo@chromium.org> Date: Tue Dec 18 01:38:49 2018 Revert "[AF] Move the IsDeletable... function from PDM to card/address classes." This reverts commit 7f17ed45c11b3e475cdb9f23c4119338a874f16f. Reason for revert: CreditCardTest.IsDeletable failed on failing on chromium.linux/Linux Tests Bug: 915976 Original change's description: > [AF] Move the IsDeletable... function from PDM to card/address classes. > > Bug: 913941 > Change-Id: I89667e635b362cc33629d8d2a9873d70e881423d > Reviewed-on: https://chromium-review.googlesource.com/c/1381138 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617297} TBR=rogerm@chromium.org,sebsg@chromium.org Change-Id: I1fa83824773a734810eed12c0bd5960aedae5f66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913941 Reviewed-on: https://chromium-review.googlesource.com/c/1381392 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#617332} [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/autofill_data_model.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/autofill_data_model.h [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/autofill_data_model_unittest.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/autofill_profile.h [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/autofill_profile_unittest.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/5c5cf076bcc56c80846a92373bdda2d907b9a3b6/components/autofill/core/common/autofill_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58cf70acc9696137329e1d3c61d16b56b35f96d6 commit 58cf70acc9696137329e1d3c61d16b56b35f96d6 Author: sebsg <sebsg@chromium.org> Date: Thu Dec 20 21:54:17 2018 Reland "[AF] Move the IsDeletable... function from PDM to card/address classes." Original change's description: > Revert "[AF] Move the IsDeletable... function from PDM to card/address classes." > > This reverts commit 7f17ed45c11b3e475cdb9f23c4119338a874f16f. > > Reason for revert: CreditCardTest.IsDeletable failed on failing on chromium.linux/Linux Tests > > Bug: 915976 > > Original change's description: > > [AF] Move the IsDeletable... function from PDM to card/address classes. > > > > Bug: 913941 > > Change-Id: I89667e635b362cc33629d8d2a9873d70e881423d > > Reviewed-on: https://chromium-review.googlesource.com/c/1381138 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#617297} > > TBR=rogerm@chromium.org,sebsg@chromium.org > > Change-Id: I1fa83824773a734810eed12c0bd5960aedae5f66 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 913941 > Reviewed-on: https://chromium-review.googlesource.com/c/1381392 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617332} TBR=horo@chromium.org,rogerm@chromium.org,sebsg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 915976 , 913941 Change-Id: I7c024efbf74116eb66dbc73c9a02668baf3b74b4 Reviewed-on: https://chromium-review.googlesource.com/c/1384647 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618344} [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/autofill_data_model.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/autofill_data_model.h [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/autofill_data_model_unittest.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/autofill_profile.h [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/autofill_profile_unittest.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/58cf70acc9696137329e1d3c61d16b56b35f96d6/components/autofill/core/common/autofill_constants.h
Comment 1 by se...@chromium.org
, Dec 17Status: Started (was: Available)