New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 913939 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 904390



Sign in to add a comment

USS/TwoClientAutofillProfileSyncTest.SyncHistogramsSanity/0 in sync_integration_tests fails on chromium.mac/Mac10.10 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 11

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fhorschig@google.com

There is a recent failure of USS/TwoClientAutofillProfileSyncTest.SyncHistogramsSanity/0:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/37222

This test has a history of flakiness on all Mac builders (but no other platforms):
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=TwoClientAutofillProfileSyncTest.SyncHistogramsSanity

It should be disabled (ideally just for param 0) on Mac.

Error log:
[ RUN      ] USS/TwoClientAutofillProfileSyncTest.SyncHistogramsSanity/0
[32983:779:1211/045541.228101:10708165983599:WARNING:loopback_server.cc(719)] Loopback sync persistent state file does not exist.
[32983:5127:1211/045541.358660:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated.
[04:55:41.412] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181
<<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'

[04:55:41.486] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245
[04:55:41.486] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946
[32983:106755:1211/045542.490394:WARNING:sync_encryption_handler_impl.cc(1080)] Nigori had empty encryption keybag.
[32983:106755:1211/045542.492176:WARNING:sync_encryption_handler_impl.cc(1080)] Nigori had empty encryption keybag.
[32983:779:1211/045542.545110:ERROR:account_tracker.cc(263)] OnOAuthError
[32983:779:1211/045542.545136:WARNING:account_tracker.cc(189)] Failed to get UserInfo for gaia_id_for_user_gmail.com
[32983:779:1211/045542.547620:ERROR:account_tracker.cc(263)] OnOAuthError
[32983:779:1211/045542.547644:WARNING:account_tracker.cc(189)] Failed to get UserInfo for gaia_id_for_user_gmail.com
../../base/test/metrics/histogram_tester.cc:202: Failure
Expected equality of these values:
  expected_count
    Which is: 2
  actual_count
    Which is: 1
Histogram "Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE" does not have the right number of samples (2) in the expected bucket (3). It has (1).
Stack trace:
0   sync_integration_tests              0x00000001020f79cb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   sync_integration_tests              0x00000001020f7389 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   sync_integration_tests              0x00000001051cadd6 base::HistogramTester::CheckBucketCount(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, int, base::HistogramSamples const&) const + 534
3   sync_integration_tests              0x00000001051cb21e base::HistogramTester::ExpectBucketCount(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, int) const + 430
4   sync_integration_tests              0x000000010204a78f (anonymous namespace)::TwoClientAutofillProfileSyncTest_SyncHistogramsSanity_Test::RunTestOnMainThread() + 5455
5   sync_integration_tests              0x000000010a6252fb content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
6   sync_integration_tests              0x0000000105617e5f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
7   sync_integration_tests              0x0000000105616cbd ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
8   sync_integration_tests              0x00000001031cfc42 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
9   sync_integration_tests              0x0000000103635bd7 content::StartupTaskRunner::RunAllTasksNow() + 39
10  sync_integration_tests              0x00000001031ce7eb content::BrowserMainLoop::CreateStartupTasks() + 683
11  sync_integration_tests              0x00000001031d1e45 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
12  sync_integration_tests              0x00000001031ccc52 content::BrowserMain(content::MainFunctionParams const&) + 178
13  sync_integration_tests              0x0000000104b484c1 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 241
14  sync_integration_tests              0x0000000104b483a4 content::ContentMainRunnerImpl::Run(bool) + 292
15  sync_integration_tests              0x0000000107dbf450 service_manager::Main(service_manager::MainParams const&) + 2352
16  sync_integration_tests              0x0000000104b47554 content::ContentMain(content::ContentMainParams const&) + 68
17  sync_integration_tests              0x000000010a624f4d content::BrowserTestBase::SetUp() + 2829
18  sync_integration_tests              0x0000000104f42211 InProcessBrowserTest::SetUp() + 529
19  sync_integration_tests              0x0000000104f2c93e SyncTest::SetUp() + 766

../../base/test/metrics/histogram_tester.cc:217: Failure
Expected equality of these values:
  expected_count
    Which is: 3
  actual_count
    Which is: 2
Histogram "Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE" does not have the right total number of samples (3). It has (2).
Stack trace:
0   sync_integration_tests              0x00000001020f79cb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   sync_integration_tests              0x00000001020f7389 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   sync_integration_tests              0x00000001051cb013 base::HistogramTester::CheckTotalCount(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, base::HistogramSamples const&) const + 483
3   sync_integration_tests              0x00000001051cb2b3 base::HistogramTester::ExpectTotalCount(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) const + 99
4   sync_integration_tests              0x000000010204a800 (anonymous namespace)::TwoClientAutofillProfileSyncTest_SyncHistogramsSanity_Test::RunTestOnMainThread() + 5568
5   sync_integration_tests              0x000000010a6252fb content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
6   sync_integration_tests              0x0000000105617e5f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
7   sync_integration_tests              0x0000000105616cbd ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
8   sync_integration_tests              0x00000001031cfc42 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
9   sync_integration_tests              0x0000000103635bd7 content::StartupTaskRunner::RunAllTasksNow() + 39
10  sync_integration_tests              0x00000001031ce7eb content::BrowserMainLoop::CreateStartupTasks() + 683
11  sync_integration_tests              0x00000001031d1e45 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
12  sync_integration_tests              0x00000001031ccc52 content::BrowserMain(content::MainFunctionParams const&) + 178
13  sync_integration_tests              0x0000000104b484c1 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 241
14  sync_integration_tests              0x0000000104b483a4 content::ContentMainRunnerImpl::Run(bool) + 292
15  sync_integration_tests              0x0000000107dbf450 service_manager::Main(service_manager::MainParams const&) + 2352
16  sync_integration_tests              0x0000000104b47554 content::ContentMain(content::ContentMainParams const&) + 68
17  sync_integration_tests              0x000000010a624f4d content::BrowserTestBase::SetUp() + 2829
18  sync_integration_tests              0x0000000104f42211 InProcessBrowserTest::SetUp() + 529
19  sync_integration_tests              0x0000000104f2c93e SyncTest::SetUp() + 766

[32983:779:1211/045545.141080:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[32983:779:1211/045545.141110:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] USS/TwoClientAutofillProfileSyncTest.SyncHistogramsSanity/0, where GetParam() = false (3920 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a648a7b293a457600dee0518a5a8e7c52af542

commit 75a648a7b293a457600dee0518a5a8e7c52af542
Author: Friedrich Horschig [CET] <fhorschig@chromium.org>
Date: Tue Dec 11 14:07:33 2018

Revert "Add autofill_profile integration test for UMA Sync.ModelTypeEntityChange3"

This reverts commit 05142837eebe9a1c5cde711f09d21fdbb195ca4d.

Reason for revert: Added test flakes on most Mac versions.

Bug: 913939

Original change's description:
> Add autofill_profile integration test for UMA Sync.ModelTypeEntityChange3
> 
> The new test is similar to the existing PersonalDataManagerSanity test,
> but adds checks for the Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE
> histogram.
> Compared to PersonalDataManagerSanity, the new test skips the step of
> adding a duplicate profile, since that seems to produce flaky results.
> 
> Bug: 904390
> Change-Id: Ic85050dcab80e53ea1a5e1fa63f61db5e6c2cb09
> Reviewed-on: https://chromium-review.googlesource.com/c/1369778
> Reviewed-by: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615461}

TBR=treib@chromium.org,jkrcal@chromium.org

Change-Id: I1da849dfe70d5523b8d211d0d6d592c101672456
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 904390
Reviewed-on: https://chromium-review.googlesource.com/c/1371888
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615512}
[modify] https://crrev.com/75a648a7b293a457600dee0518a5a8e7c52af542/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc

Blocking: 904390
Cc: jkrcal@chromium.org
Components: Services>Sync
Labels: -Sheriff-Chromium OS-Mac Type-Bug
Owner: treib@chromium.org
Status: Assigned (was: Available)
treib: Could you please have another look and reland a version that either works for Macs or excludes the one failing case?
 Issue 913936  has been merged into this issue.
I could repro the failure locally on Mac, though only in 1 out of 20 runs. The "/1" (i.e. USS) version of the test seems to pass consistently.

Comment 5 by treib@chromium.org, Jan 16 (6 days ago)

Cc: treib@chromium.org
Owner: ----
Status: Available (was: Assigned)
Marking Available for now since I'm not actively looking at this.

Sign in to add a comment