New issue
Advanced search Search tips

Issue 913932 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Flaky-Test: external/wpt/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html



Sign in to add a comment

target_blank_implicit_noopener.tentative.html in webkit_layout_tests failing on Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 11

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fhorschig@google.com

The webkit_layout_tests test target_blank_implicit_noopener.tentative.html failed on 6/6 Mac10.13 Tests (dbg) with the preceeding 15+ tests being clean:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7220
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7221
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7222
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7223
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7224
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7225

So although FindIt presumes flakiness, it looks like this test is fairly consistent in failures or timeouts:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=target_blank_implicit_noopener.tentative.html

It looks like it's related to the latest wpt roll: https://crrev.com/c/1371217
Therefore, I'll add the failure expectation.

Current log snippet:
target_blank_implicit_noopener.tentative.html output stderr lines:
00:33:11.393 1601   objc[3381]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib (0x172171458) and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework (0x111aff8f0). One of the two will be used. Which one is undefined.
00:33:11.393 1601   objc[3382]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib (0x170826458) and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework (0x11379b8f0). One of the two will be used. Which one is undefined.
00:33:11.393 1601   objc[3383]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib (0x16f459458) and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework (0x10ede78f0). One of the two will be used. Which one is undefined.
00:33:11.393 1601   objc[3384]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib (0x16d650458) and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework (0x10cfde8f0). One of the two will be used. Which one is undefined.
00:33:11.393 1601   objc[3385]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib (0x16e27a458) and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework (0x111a578f0). One of the two will be used. Which one is undefined.
00:33:11.393 1601   objc[3386]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib (0x16fd1a458) and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework (0x10f6ab8f0). One of the two will be used. Which one is undefined.
00:33:11.395 1545 [3982/6654] external/wpt/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html failed unexpectedly (test timed out)
00:33:11.394 1601 worker/5 killing primary driver
00:33:11.394 1601 worker/5 killing secondary driver
00:33:11.394 1601 worker/5 external/wpt/html/semantics/links/links-created-by-a-and-area-elements/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f23bb9f1a536c3cfcd01432b3b5c522f4cbb5b2

commit 2f23bb9f1a536c3cfcd01432b3b5c522f4cbb5b2
Author: Friedrich Horschig [CET] <fhorschig@chromium.org>
Date: Tue Dec 11 14:55:31 2018

Mark target_blank_implicit_noopener.tentative.html as failing on Mac

This test is consistently failing on Mac since the last wpt roll.

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 913932, 626703

TBR=robertma@chromium.org

Change-Id: I071d68a9003edecf4b24b10b4adfe1c86cf7da61
Reviewed-on: https://chromium-review.googlesource.com/c/1371904
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615522}
[modify] https://crrev.com/2f23bb9f1a536c3cfcd01432b3b5c522f4cbb5b2/third_party/blink/web_tests/TestExpectations

Labels: -Sheriff-Chromium OS-Mac Type-Bug
Owner: robertma@chromium.org
Status: Assigned (was: Available)
robertma: do you know the owner for this? (The cl description had plenty owners but nobody for this test directory)

(Expectation set and assigned --> remove from sheriff queue)
Cc: hayato@chromium.org
 Issue 915439  has been merged into this issue.
Project Member

Comment 4 by Findit, Dec 22

Flaky-Test: external/wpt/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html
Labels: Test-Flaky Test-Findit-Analyzed

Findit identified the culprit r615443 as introducing flaky test(s)
summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYzI1NzdjOTAwM2ZmNzkyZGVlYTkzM2M2NTczZjIwMjQyZWNkOGYxYQw

Please revert the culprit or disable the test(s) asap. If you are the owner,
please fix!

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r615443&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYzI1NzdjOTAwM2ZmNzkyZGVlYTkzM2M2NTczZjIwMjQyZWNkOGYxYQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Components: Blink>HTML
Owner: ----
Status: Untriaged (was: Assigned)
Tentatively assign to the Blink>HTML component
Status: Available (was: Untriaged)

Sign in to add a comment