New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913930 link

Starred by 1 user
Status: Fixed
Owner:
█ caryclark@google.com
Last visit > 30 days ago
Closed: Dec 13
Cc:
fmalita@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove reference to SkPath::pathRefIsValid

Project Member Reported by caryclark@google.com, Dec 11 
Chrome calls SkPath::pathRefIsValid() always in tandem with SkPath::isValid(). SkPathRef is a Skia internal detail that need not be exposed. To clean this up:

 - Add SK_SUPPORT_DIRECT_PATHREF_VALIDATION temporarily to remove this dependency from Chrome, and remove call to SkPath::pathRefIsValid().

- Remove SK_SUPPORT_DIRECT_PATHREF_VALIDATION from Skia.

- Remove SK_SUPPORT_DIRECT_PATHREF_VALIDATION from Chrome.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/aa3b2917173006861ab935ece048257b51cf48b8

commit aa3b2917173006861ab935ece048257b51cf48b8
Author: Cary Clark <caryclark@skia.org>
Date: Tue Dec 11 17:10:09 2018

bracket SkPath pathRefIsValid with define

Add defines around the places calls
SkPath::pathRefIsValid()

R=fmalita@chromium.org

Bug:913930
Change-Id: Iffaa85cecf127cf8cb405dffe76666f9184de76e
Reviewed-on: https://skia-review.googlesource.com/c/176583
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/aa3b2917173006861ab935ece048257b51cf48b8/fuzz/FuzzCommon.cpp
[modify] https://crrev.com/aa3b2917173006861ab935ece048257b51cf48b8/tests/PathTest.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49da65ca61e33f78860de4c8a30b9b4f0627b04a

commit 49da65ca61e33f78860de4c8a30b9b4f0627b04a
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Dec 11 20:30:33 2018

Roll src/third_party/skia 3bdc3f5f9c0b..12659a46b9d9 (8 commits)

https://skia.googlesource.com/skia.git/+log/3bdc3f5f9c0b..12659a46b9d9


git log 3bdc3f5f9c0b..12659a46b9d9 --date=short --no-merges --format='%ad %ae %s'
2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f5c88e7e1c1a..be607ad63609 (1 commits)
2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader afb8cd307bc5..a233ceaecd85 (1 commits)
2018-12-11 mtklein@google.com Try out clang-tidy, starting with bugprone-use-after-move
2018-12-11 reed@google.com Revert "Treat kWEBP encode with quality=100 as lossless"
2018-12-11 caryclark@skia.org bracket SkPath pathRefIsValid with define
2018-12-11 reed@google.com impl intercepts with fonts
2018-12-11 michaelludwig@google.com Consolidate stroke-rect ops and use GrFillRectOp instead of GrNonAA/AARectOp
2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7cfb50cd5f50..afb8cd307bc5 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@12659a46b9d9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:913930 
TBR=ethannicholas@chromium.org

Change-Id: Ic3060e64bc1a7dfa8403d17decd7fc3cd341f804
Reviewed-on: https://chromium-review.googlesource.com/c/1372404
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615648}
[modify] https://crrev.com/49da65ca61e33f78860de4c8a30b9b4f0627b04a/DEPS
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5409e1501eb7bf7d5e23c581b86be623582938

commit ef5409e1501eb7bf7d5e23c581b86be623582938
Author: Cary Clark <caryclark@google.com>
Date: Wed Dec 12 17:22:07 2018

remove ref to skia internal concept

Switch chrome to use interface that
does not expose internal Skia concept.

R=fmalita@chromium.org, danakj@chromium.org

Bug:  913930 
Change-Id: I3373c791095d4eeb3590f23f474e9c5a3f88a207
Reviewed-on: https://chromium-review.googlesource.com/c/1371924
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Cary Clark <caryclark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615936}
[modify] https://crrev.com/ef5409e1501eb7bf7d5e23c581b86be623582938/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/ef5409e1501eb7bf7d5e23c581b86be623582938/skia/config/SkUserConfig.h

Comment 4 by caryclark@google.com, Dec 13

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/3d6b438b9973f123d684c826df78ab0bb2e17501

commit 3d6b438b9973f123d684c826df78ab0bb2e17501
Author: Cary Clark <caryclark@skia.org>
Date: Thu Dec 13 14:29:09 2018

remove legacy pathref validation

Chrome added a public method to validate SkPathRef,
but always called it when validating SkPath. We did too.

Remove the SkPathRef entry point, validate SkPathRef
when validating SkPath, and remove Skia's callers.
(Chrome has already been fixed.)

TBR=reed@google.com
R=fmalita@chromium.org

Bug:913930
Change-Id: I0828b00b42cc1f031b4216ddeace50f80aa21e62
Reviewed-on: https://skia-review.googlesource.com/c/177065
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/3d6b438b9973f123d684c826df78ab0bb2e17501/fuzz/FuzzCommon.cpp
[modify] https://crrev.com/3d6b438b9973f123d684c826df78ab0bb2e17501/tests/PathTest.cpp
[modify] https://crrev.com/3d6b438b9973f123d684c826df78ab0bb2e17501/include/core/SkPath.h
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdaee2bf7ee7866976ac35a740a9855c5284ab71

commit fdaee2bf7ee7866976ac35a740a9855c5284ab71
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Dec 13 22:05:51 2018

Roll src/third_party/skia c9b7c720ddd3..cb6b4bde0c2e (16 commits)

https://skia.googlesource.com/skia.git/+log/c9b7c720ddd3..cb6b4bde0c2e


git log c9b7c720ddd3..cb6b4bde0c2e --date=short --no-merges --format='%ad %ae %s'
2018-12-13 cstout@google.com Add dependency for fuchsia vulkan headers
2018-12-13 egdaniel@google.com Add blacklist for vulkan intel 405.
2018-12-13 mtklein@google.com simplify fExternalCounter bookkeeping
2018-12-13 reed@google.com make ctor and setter consistent -- just take the typeface param as is
2018-12-13 fmalita@chromium.org [skottie] Add initial tracing
2018-12-13 reed@google.com undef fontmetrics flag -- rely on clients to opt in
2018-12-13 scroggo@google.com Add a test to imitate GIFImageDecoderTest.parseAndDecodeByteByByte
2018-12-13 reed@google.com use SkFont for textToGlyphs
2018-12-13 mtklein@google.com always check lock() result
2018-12-13 reed@google.com remove dead code around SkPaint::breakText
2018-12-13 reed@google.com make new ctor explicit
2018-12-13 reed@google.com use font for measuring
2018-12-13 bsalomon@google.com Move textureType() method from GrSurfaceProxy to GrTextureProxy.
2018-12-13 caryclark@skia.org remove legacy pathref validation
2018-12-13 caryclark@skia.org minor docs example fix
2018-12-13 reed@google.com add simpler constructor for SkFont


Created with:
  gclient setdep -r src/third_party/skia@cb6b4bde0c2e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:913930 
TBR=ethannicholas@chromium.org

Change-Id: I656a3af3be20500323eaf60ac407b6296e0024ed
Reviewed-on: https://chromium-review.googlesource.com/c/1376669
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616449}
[modify] https://crrev.com/fdaee2bf7ee7866976ac35a740a9855c5284ab71/DEPS
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fa7d035f88ea5650c157a339177b37753269cf

commit 71fa7d035f88ea5650c157a339177b37753269cf
Author: Cary Clark <caryclark@google.com>
Date: Thu Dec 20 21:47:30 2018

rebaseline skia convexity

Skia SkPath::isConvex() is faster and more robust, and marks
paths correctly as convex that were marked as concave. This causes
a few tests to have different pixel results; the convex renderers
are generally faster and use different rendering techniques.

Also, remove a legacy Skia flag; SkPath::pathRefIsValid() has
been removed.

R=fmalita@chromium.org

Bug: 899689, 913930 
Change-Id: Ic11a04e853e2c88444388d27f2894be287aa349d
Reviewed-on: https://chromium-review.googlesource.com/c/1379276
Commit-Queue: Cary Clark <caryclark@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618339}
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/skia/config/SkUserConfig.h
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/linux/svg/hixie/perf/001-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/linux/svg/hixie/perf/002-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/linux/transforms/shadows-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac-mac10.12/svg/hixie/perf/001-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac-mac10.12/svg/hixie/perf/002-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/fast/forms/range/input-appearance-range-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/paint/invalidation/svg/tabgroup-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/svg/hixie/perf/001-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/mac/svg/hixie/perf/002-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/fast/text/color-emoji-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/fast/text/emoticons-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/fast/text/fallback-traits-fixup-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/paint/invalidation/svg/tabgroup-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/svg/hixie/perf/001-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/svg/hixie/perf/002-expected.png
[modify] https://crrev.com/71fa7d035f88ea5650c157a339177b37753269cf/third_party/blink/web_tests/platform/win/transforms/shadows-expected.png
►

Sign in to add a comment