New issue
Advanced search Search tips

Issue 913928 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate WebViewProfileSyncServiceFactory's dependence on ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Dec 11

Issue description

This dependence looks stale, as PO2TS is no longer passed to ProfileSyncService.
 
Owner: svil...@igalia.com
Status: Started (was: Available)
Working on this
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c224c93f54e09a7f409de3ac96229b65ecc6705

commit 6c224c93f54e09a7f409de3ac96229b65ecc6705
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Dec 20 16:33:16 2018

Eliminate WebViewProfileSyncServiceFactory's dependence on PO2TS

The dependency is now stale as ProfileOAuth2TokenService is no longer
passed to ProfileSyncService.

Bug:  913928 
Change-Id: Ic2f3ccab8f9529638e18ae3e1d007f7ef1dc4284
Reviewed-on: https://chromium-review.googlesource.com/c/1386828
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618239}
[modify] https://crrev.com/6c224c93f54e09a7f409de3ac96229b65ecc6705/ios/web_view/internal/sync/web_view_profile_sync_service_factory.mm

Status: Fixed (was: Started)

Sign in to add a comment