New issue
Advanced search Search tips

Issue 913912 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 870606



Sign in to add a comment

Use per-frame task runners at mojo

Project Member Reported by hajimehoshi@chromium.org, Dec 11

Issue description

This is related to crbug/870606

Using per-frame task runners is necessary to assure that JavaScript is executed only on per-frame task runners, which is necessary for bfcache.
 
Blocking: 870606
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94bb454de9f708d00da0b3cba5f7a25f99dace6

commit c94bb454de9f708d00da0b3cba5f7a25f99dace6
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Dec 12 12:05:30 2018

Pass per-frame task runner to mojo::Binding in renderer.

Use per-frame task runners instead of per-thread task runners for bfcache.

This is based on Alexander's CL https://chromium-review.googlesource.com/c/chromium/src/+/1367325

Bug: 913912
Change-Id: If41723bc50fb402414e8108a4f99755c982e33af
Reviewed-on: https://chromium-review.googlesource.com/c/1369748
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615859}
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/app_banner/before_install_prompt_event.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/locks/lock_manager.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/nfc/nfc.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/permissions/permission_status.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/presentation/presentation_controller.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/presentation/presentation_receiver.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/websockets/websocket_handle_impl.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/modules/webusb/usb.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/platform/scheduler/main_thread/task_type_names.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc
[modify] https://crrev.com/c94bb454de9f708d00da0b3cba5f7a25f99dace6/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d0933dc5d1650065a33c41a6cece28f480dfd01

commit 9d0933dc5d1650065a33c41a6cece28f480dfd01
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Dec 17 07:17:22 2018

Pass per-frame task runners to mojo::MakeRequest in blink.

Use per-frame task runners instead of per-thread task runners for bfcache.

This is based on Alexander's CL https://chromium-review.googlesource.com/c/chromium/src/+/1367326/2

Bug: 913912
Change-Id: I0ed2783d5331f927464fd8c9c74c271afdd4950c
Reviewed-on: https://chromium-review.googlesource.com/c/1369759
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617059}
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/battery/battery_dispatcher.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/cookie_store/window_cookie_store.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/credentialmanager/credential_manager_proxy.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/installedapp/installed_app_controller.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/keyboard/keyboard_lock.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/locks/lock_manager.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/nfc/nfc.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/payments/payment_manager.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/permissions/permissions.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/shapedetection/barcode_detector.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/shapedetection/face_detector.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/shapedetection/text_detector.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/speech/speech_recognition.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/vr/vr_controller.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/webmidi/midi_access_initializer.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/webshare/navigator_share.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/webusb/usb.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/xr/xr.cc
[modify] https://crrev.com/9d0933dc5d1650065a33c41a6cece28f480dfd01/third_party/blink/renderer/modules/xr/xr_device.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cf02aec69538c7586be225b66b8f798d81e461a

commit 1cf02aec69538c7586be225b66b8f798d81e461a
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Dec 19 11:09:28 2018

Pass per-frame task runners at mojo's GetInterface

Use per-frame task runners instead of per-thread task runners for bfcache.

This is based on Alexander's CL https://chromium-review.googlesource.com/c/chromium/src/+/1369552/

Bug: 913912
Change-Id: Id9f86952df6b893b9c67ae376f902424e71d97f0
Reviewed-on: https://chromium-review.googlesource.com/c/1382374
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617798}
[modify] https://crrev.com/1cf02aec69538c7586be225b66b8f798d81e461a/third_party/blink/renderer/core/html/forms/file_chooser.cc
[modify] https://crrev.com/1cf02aec69538c7586be225b66b8f798d81e461a/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/1cf02aec69538c7586be225b66b8f798d81e461a/third_party/blink/renderer/modules/geolocation/geolocation.cc

> which is necessary for bfcache.

Can you elaborate - why is it necessary for bfcache?
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5c8c871eb4092b10e8718987be98ae25164c41

commit 7a5c8c871eb4092b10e8718987be98ae25164c41
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jan 10 05:44:51 2019

Use SequenceLocalStorage and SequencedTaskRunner in mojo/public/cpp

In the current mojo binding, task runners don't have to be
SingleThreadTaskRunner and SequencedTaskRunners should be enough.

This CL replaces SingleThreadTaskRunner usages with SequencedTaskRunner
in mojo/public/cpp. At the same time, this CL replaces
ThreadLocalStorage usages with SequenceLocalStorage.

Bug: 913912
Change-Id: Ib6c8af039dbfcebbcc7e83dc367b155e9666e0dd
Reviewed-on: https://chromium-review.googlesource.com/c/1386068
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621478}
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/feed/core/feed_networking_host_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/gcm_driver/gcm_client_impl_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/language/content/browser/geo_language_model_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/language/content/browser/geo_language_provider_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/ntp_snippets/remote/json_request.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/ntp_snippets/remote/json_request.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/components/suggestions/suggestions_service_impl_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/content/browser/notifications/notification_event_dispatcher_impl_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/google_apis/gcm/engine/gcm_request_test_base.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/google_apis/gcm/engine/gcm_request_test_base.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/associated_binding.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/binding.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/interface_request.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/lib/associated_binding.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/lib/binding_state.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/lib/binding_state.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/lib/connector.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/lib/message.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/mojo/public/cpp/system/simple_watcher.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/services/audio/loopback_stream_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/services/device/geolocation/public_ip_address_location_notifier_unittest.cc
[modify] https://crrev.com/7a5c8c871eb4092b10e8718987be98ae25164c41/services/network/mdns_responder_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c32bb03fb26ec37b12fdb11c28a7b27a59df1c3

commit 4c32bb03fb26ec37b12fdb11c28a7b27a59df1c3
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jan 11 04:42:10 2019

Use per-frame task runners at PushMessageClient

Use per-frame task runners instead of per-thread task runners for
bfcache.

bfcache is a new feature to freeze a tab for quick back-forwarding. When
a tab goes frozen, we can stop per-frame task runners while we cannot
per-thread task runners since per-thread task runners can be shared
between multiple tags/pages. As a frozen tab must not execute any
JavaScript, all JavaScript execution must be on per-frame task runners,
which can be suspended.

Bug: 913912
Change-Id: Ic2493e0669c8af821aa0adac03126a96274d8c90
Reviewed-on: https://chromium-review.googlesource.com/c/1404772
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621908}
[modify] https://crrev.com/4c32bb03fb26ec37b12fdb11c28a7b27a59df1c3/content/renderer/push_messaging/push_messaging_client.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46447b203383839c92d4afb7b8728a66d7b7d9bd

commit 46447b203383839c92d4afb7b8728a66d7b7d9bd
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jan 11 07:53:54 2019

Use per-frame task runners at CacheStorage

This CL switches task runners at CacheStorage from per-thread to per-frame.
The purpose of this change is to make it possible to freeze CacheStorage
tasks for bfcache.

bfcache is a new feature to freeze a tab for quick back-forwarding. When
a tab goes frozen, we can stop per-frame task runners while we cannot
per-thread task runners since per-thread task runners can be shared
between multiple tags/pages. As a frozen tab must not execute any
JavaScript, all JavaScript execution must be on per-frame task runners,
which can be suspended.

Bug: 913912
Change-Id: I2510c8c8f8ace86e0c0297a258b2192508947cfa
Reviewed-on: https://chromium-review.googlesource.com/c/1404899
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621943}
[modify] https://crrev.com/46447b203383839c92d4afb7b8728a66d7b7d9bd/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/46447b203383839c92d4afb7b8728a66d7b7d9bd/third_party/blink/renderer/modules/cache_storage/cache.h
[modify] https://crrev.com/46447b203383839c92d4afb7b8728a66d7b7d9bd/third_party/blink/renderer/modules/cache_storage/cache_storage.cc
[modify] https://crrev.com/46447b203383839c92d4afb7b8728a66d7b7d9bd/third_party/blink/renderer/modules/cache_storage/cache_test.cc
[modify] https://crrev.com/46447b203383839c92d4afb7b8728a66d7b7d9bd/third_party/blink/renderer/platform/mojo/interface_invalidator_test.cc
[modify] https://crrev.com/46447b203383839c92d4afb7b8728a66d7b7d9bd/third_party/blink/renderer/platform/mojo/revocable_interface_ptr.h

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8308609b0bc4cde9e5f652fb0e754e579cd22c8

commit a8308609b0bc4cde9e5f652fb0e754e579cd22c8
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jan 15 12:28:58 2019

Use per-frame task runners at WebIDBFactoryImpl

This CL switches task runners at IndexedDB from per-thread to
per-frame. The purpose of this change is to make it possible to freeze
WebIDBFactoryImpl tasks for bfcache.

bfcache is a new feature to freeze a tab for quick back-forwarding. When
a tab goes frozen, we can stop per-frame task runners while we cannot
per-thread task runners since per-thread task runners can be shared
between multiple tags/pages. As a frozen tab must not execute any
JavaScript, all JavaScript execution must be on per-frame task runners,
which can be suspended.

Bug: 913912
Change-Id: I93e9ed12b7a52a6f0b41d414436a24f35b36a0a8
Reviewed-on: https://chromium-review.googlesource.com/c/1406768
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622827}
[modify] https://crrev.com/a8308609b0bc4cde9e5f652fb0e754e579cd22c8/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[modify] https://crrev.com/a8308609b0bc4cde9e5f652fb0e754e579cd22c8/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a45b6dcd37809569df9aab025ac57b19b37006

commit 05a45b6dcd37809569df9aab025ac57b19b37006
Author: Chase Phillips <cmp@chromium.org>
Date: Wed Jan 16 02:18:32 2019

IndexedDB: Bind all renderer Mojo objects with the IndexedDB task runner

For browser->renderer interfaces, this change ensures that calls issued
by the browser will run in the renderer in the IndexedDB task queue task
runner.

For renderer->browser interfaces with no return calls, this change is
aesthetic.  The calls would have been issued by script running in a
context and would already have a high priority.

Eventually any Mojo interface method that takes a callback will be
updated to use Mojo's async callbacks.  This change means that, when
that happens, the Mojo task will run in the IDB task queue.

Bug: 717812, 913912
Change-Id: I976c36c33214652c2b6e0b4beecab2a1717c1d40
Reviewed-on: https://chromium-review.googlesource.com/c/1410171
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623045}
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/idb_factory.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
[modify] https://crrev.com/05a45b6dcd37809569df9aab025ac57b19b37006/third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h

Sign in to add a comment