New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913901 link

Starred by 2 users
Status: Verified
Owner:
za...@chromium.org
Closed: Dec 12
Cc:
chirantan@chromium.org
matth...@chromium.org
█ caveh@chromium.org
hidehiko@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

crostini_client unit tests fails on unsafe_misc::tests::same_as_df

Project Member Reported by fukino@google.com, Dec 11 
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8927459670710137264

In this build, many targets (cyan-paradin, edgar-paradin, etc...) fail with the same error: unsafe_misc::tests::same_as_df of crostini_client unit test.

Example log: https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8927458193990188368/+/steps/UnitTest/0/stdout

This error can be reproduced locally by applying 
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1370845
However, I have no idea how this CL affects the unit test result.

+zachr@ who wrote the test.
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1352841/

Comment 1 by fukino@google.com, Dec 11 

zachr@, 
I'm not familiar with how the unit test runs, but is there a possibility that that other processes consume disk space between statvfs call and df command?
https://cs.corp.google.com/chromeos_public/src/platform2/vm_tools/crostini_client/unsafe_misc.rs?rcl=8b3d056fd71efc2df8084bb130d3a7d8cde08901&l=50

Comment 2 by fukino@google.com, Dec 11 

hidehiko@ told me that he saw the same issue on pre-CQ.
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8927451966692678816
I guess the test actually has the problem on ToT.

Comment 3 by fukino@google.com, Dec 11

Cc: hidehiko@chromium.org

Comment 4 by fukino@google.com, Dec 11

Cc: caveh@chromium.org matth...@chromium.org
A CL to disable the failing unit test in ToT is in CQ.
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1371686

Comment 5 by za...@chromium.org, Dec 11 

Yeah, it would seem like the amount of free disk space changes during that unit test. Ignoring it seems like the right choice.

Comment 6 by matth...@chromium.org, Dec 11 

 Issue 914040  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/37f1b440073771705e469cae6f6f1d34ae22ec62

commit 37f1b440073771705e469cae6f6f1d34ae22ec62
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Dec 11 23:50:11 2018

vm_tools: crostini_client: Disable same_as_df test in crostini_client.

This test seems to affect the current CQ failures.
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8927449465797922336
Let me disable the test for now.

TEST=cargo test
BUG= chromium:913901 
Change-Id: I3752843f91460fb93c50387e4a7ede8e95cedd01
Reviewed-on: https://chromium-review.googlesource.com/c/1371686
Commit-Queue: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/37f1b440073771705e469cae6f6f1d34ae22ec62/vm_tools/crostini_client/unsafe_misc.rs

Comment 8 by fukino@chromium.org, Dec 12

Cc: -za...@chromium.org
Owner: za...@chromium.org
Status: Assigned (was: Untriaged)
Assigning this to zachr@ for fixing/enabling the test.

Comment 9 by za...@chromium.org, Dec 12

Status: Verified (was: Assigned)
The fix was chumped and the test can't be easily fixed for CI purposes. The test has served its purpose as far as I'm concerned.
►

Sign in to add a comment