New issue
Advanced search Search tips

Issue 913887 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Rename ArrayBuffer 'Neuter' operation to 'Detach'

Project Member Reported by titzer@google.com, Dec 11

Issue description

Throughout both the Chromium and V8 codebases, we use the term 'neuter' for the operation which detaches an ArrayBuffer, e.g. to transfer via postMessage(). This is a deprecated term, and the preferred term is 'detach', which is actually used in the EcmaScript specification.

We should migrate all uses in the codebase and in error messages to the proper terminology.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f68ee6e7e49ac33b3ba870f7287555c5dae9051e

commit f68ee6e7e49ac33b3ba870f7287555c5dae9051e
Author: Ben L. Titzer <titzer@chromium.org>
Date: Tue Dec 11 11:57:30 2018

[typedarrays] Use Detach instead of Neuter

This is purely a renaming change. The ES spec uses the term 'detach'
for the process of removing the backing store of a typed array, while
V8 uses the historical term 'neuter'. Update our internal implementation,
including method names and flag names, to match the spec.

Note that some error messages still use the term 'neuter' since error
messages are asserted by some embedder tests, like layout tests.

R=bmeurer@chromium.org, yangguo@chromium.org, mstarzinger@chromium.org, mlippautz@chromium.org
BUG=chromium:913887

Change-Id: I62f1c3ac9ae67ba01d612a5221afa3d92deae272
Reviewed-on: https://chromium-review.googlesource.com/c/1370036
Commit-Queue: Ben Titzer <titzer@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58149}
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/include/v8.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/api.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/builtins/builtins-arraybuffer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/builtins/builtins-sharedarraybuffer-gen.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/builtins/builtins-sharedarraybuffer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/builtins/builtins-typed-array.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/code-stub-assembler.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/code-stub-assembler.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/compiler/js-heap-broker.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/counters.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/d8.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/deoptimize-reason.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/elements.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/ic/accessor-assembler.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/isolate-inl.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/isolate.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/isolate.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/js/typedarray.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/message-template.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/objects-printer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/objects.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/objects/js-array-buffer-inl.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/objects/js-array-buffer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/objects/js-array-buffer.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/roots.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/runtime/runtime-atomics.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/runtime/runtime-futex.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/runtime/runtime-typedarray.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/runtime/runtime.h
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/snapshot/serializer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/value-serializer.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/wasm/module-compiler.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/src/wasm/wasm-memory.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/cctest/test-api.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/cctest/test-serialize.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/cctest/wasm/test-run-wasm-module.cc
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/array-indexing-receiver.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/compiler/dataview-get.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/compiler/dataview-neutered.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/array-iterator-detached.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/array-iterator-turbo.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/regress/regress-5929-1.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-construct-by-array-like.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-copywithin.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-every.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-fill.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-filter.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-find.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-findindex.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-foreach.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-from-detached-typedarray.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-from.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-indexing.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-iteration.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-map.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-neutered.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-reduce.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-reverse.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-slice.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-sort.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray-tostring.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es6/typedarray.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/es7/array-includes-receiver.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/messages.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/neuter-twice.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-353004.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-4964.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-707410.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-840106.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-904707.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-crbug-691323.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/mjsunit/regress/regress-crbug-867776.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/test/test262/detachArrayBuffer.js
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/tools/gen-postmortem-metadata.py
[modify] https://crrev.com/f68ee6e7e49ac33b3ba870f7287555c5dae9051e/tools/v8heapconst.py

Components: -Blink

Sign in to add a comment