New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913871 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
vapier@chromium.org
yamaguchi@chromium.org
█ oka@chromium.org
hidehiko@chromium.org
nya@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Migrate generate_pc_file.sh into gn.

Project Member Reported by hidehiko@chromium.org, Dec 11 
Currently generate_pc_file.sh is used to generate .pc file, which is executed from .ebuild/.eclass files.

Now we're supporting a template to generate .pc file, so those should be migrated into gn for simplicity.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/e1f598f7891edd36a940793b4344e9c08af0f2c1

commit e1f598f7891edd36a940793b4344e9c08af0f2c1
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:48 2019

libchrome: Annotate "-l" for libs and libs_private.

To support other .pc file generation,
"-l" prepending is moved out from generate-pc.py.

BUG=chromium:913871
TEST=Build.

Change-Id: I8bfbc480edc23ebe71c6374162e807d173b31ac9
Reviewed-on: https://chromium-review.googlesource.com/1409623
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/e1f598f7891edd36a940793b4344e9c08af0f2c1/BUILD.gn
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cbfb5722962893b0c05950abfb105d01eb6cfead

commit cbfb5722962893b0c05950abfb105d01eb6cfead
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:54 2019

common-mk: Remove "-l" appending from generate-pc.py.

That should now be done in .gn files, so that Libs/Libs.private
section can have non "-l" prefixed flags, such as -L/path/to/libdir.

BUG=chromium:913871
TEST=Build with libchrome.

Change-Id: I600f99fa1ea6e23a6110b4ec9d718182254bca49
Reviewed-on: https://chromium-review.googlesource.com/1409666
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/cbfb5722962893b0c05950abfb105d01eb6cfead/common-mk/generate-pc.py
[modify] https://crrev.com/cbfb5722962893b0c05950abfb105d01eb6cfead/common-mk/pkg_config.gni
►

Sign in to add a comment