New issue
Advanced search Search tips

Issue 913848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 898632



Sign in to add a comment

ExtensionApiTabTest.UpdateWindowResize fails network_service_browser_tests (failing on chromium.mac/Mac10.12 Tests)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 11

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fhorschig@google.com

ExtensionApiTabTest.UpdateWindowResize fails network_service_browser_tests (failing on chromium.mac/Mac10.12 Tests)

Builders failed on: 
- Mac10.12 Tests:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests

The test is failing consistently (8/8) since
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17505

Most recent failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17513

[ RUN      ] ExtensionApiTabTest.UpdateWindowResize
[30121:4099:1210/185240.834092:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated.
[30121:775:1210/185241.868437:INFO:CONSOLE(0)] "[FAIL] testCurrentWindowResize: API Test Error in testCurrentWindowResize
Actual: 520
Expected: 500
Error
    at extensions::test:243:18
    at chrome-extension://okmoadclicoiebokfkibjpgcibkikpgg/test.js:67:23
    at safeFunctionApply (extensions::test:288:26)
    at extensions::test:313:18", source: chrome-extension://okmoadclicoiebokfkibjpgcibkikpgg/test.html (0)
[30121:775:1210/185242.083569:INFO:CONSOLE(0)] "[FAIL] testResizeNormal: API Test Error in testResizeNormal
Actual: 520
Expected: 510
Error
    at extensions::test:243:18
    at changeHeight (chrome-extension://okmoadclicoiebokfkibjpgcibkikpgg/test.js:33:15)
    at safeFunctionApply (extensions::test:288:26)
    at extensions::test:313:18", source: chrome-extension://okmoadclicoiebokfkibjpgcibkikpgg/test.html (0)
[30121:775:1210/185242.682317:INFO:CONSOLE(0)] "[SUCCESS] testResizePopup", source: chrome-extension://okmoadclicoiebokfkibjpgcibkikpgg/test.html (0)
[30121:775:1210/185243.118929:INFO:CONSOLE(0)] "[SUCCESS] testResizePanel", source: chrome-extension://okmoadclicoiebokfkibjpgcibkikpgg/test.html (0)
../../chrome/browser/extensions/extension_tabs_apitest.cc:249: Failure
Value of: RunExtensionTest("window_update/resize")
  Actual: false
Expected: true
Failed 2 of 4 tests
Stack trace:
0   browser_tests                       0x00000001081efdbb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   browser_tests                       0x00000001081ef779 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   browser_tests                       0x0000000107bc72f2 ExtensionApiTabTest_UpdateWindowResize_Test::RunTestOnMainThread() + 274
3   browser_tests                       0x000000010b715c8b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   browser_tests                       0x000000010b15cb4f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
5   browser_tests                       0x000000010b15b9ad ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
6   browser_tests                       0x000000010928fcd2 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
7   browser_tests                       0x00000001096f3287 content::StartupTaskRunner::RunAllTasksNow() + 39
8   browser_tests                       0x000000010928e87b content::BrowserMainLoop::CreateStartupTasks() + 683
9   browser_tests                       0x0000000109291ed5 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
10  browser_tests                       0x000000010928cce2 content::BrowserMain(content::MainFunctionParams const&) + 178
11  browser_tests                       0x000000010abe5f41 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 241
12  browser_tests                       0x000000010abe5e24 content::ContentMainRunnerImpl::Run(bool) + 292
13  browser_tests                       0x000000010df4fedb service_manager::Main(service_manager::MainParams const&) + 3051
14  browser_tests                       0x000000010abe4fd4 content::ContentMain(content::ContentMainParams const&) + 68
15  browser_tests                       0x000000010b7158dd content::BrowserTestBase::SetUp() + 2829
16  browser_tests                       0x000000010b0d0181 InProcessBrowserTest::SetUp() + 529

[30121:28163:1210/185243.410559:ERROR:browser_process_sub_thread.cc(209)] Waited 14 ms for network service
[30121:775:1210/185243.427264:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[30121:775:1210/185243.427290:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] ExtensionApiTabTest.UpdateWindowResize, where TypeParam =  and GetParam() =  (2768 ms)
 
 Issue 913849  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/043c95f211872d0739ed6d94e8c54ca2e29757cc

commit 043c95f211872d0739ed6d94e8c54ca2e29757cc
Author: Friedrich Horschig [CET] <fhorschig@chromium.org>
Date: Tue Dec 11 08:49:32 2018

Revert "Move toolbar to new FlexLayout, demonstrating new layout manager."

This reverts commit d080cfa6b2816045a60cc2d16d2bf67ff1c15d8a.

Reason for revert: Suspected culprit for ExtensionApiTabTest.UpdateWindowResize failure on network_service_browser_tests (failing on chromium.mac/Mac10.12 Tests).

Bug:  913848 

Original change's description:
> Move toolbar to new FlexLayout, demonstrating new layout manager.
> 
> Vastly simplifies layout in the toolbar and makes it mostly declarative with a
> single init function, rather than complex, bespoke - and sometimes incorrect -
> Layout(), GetMinimumSize(), etc. methods.
> 
> Because of a logical change in the way the UI works when an extension is
> uninstalled, we uncovered a possible read-after-free in the extension install
> UI (shows up in some ASAN tests). So we plumbed the scoped_refptr through from
> crx_installer to the UI so that the memory would be valid until the bubble is
> closed.
> 
> See parent CL for FlexLayout details and future work.
> 
> Bug: 898632
> Change-Id: I2cfe5b6119dc2886f88ae12675f8184cf90d56fd
> Reviewed-on: https://chromium-review.googlesource.com/c/1331041
> Commit-Queue: Dana Fried <dfried@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615372}

TBR=rdevlin.cronin@chromium.org,bsep@chromium.org,dfried@chromium.org

Change-Id: Ie93f170c2c6048072820f2d6dc9950f75bc4aa94
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898632
Reviewed-on: https://chromium-review.googlesource.com/c/1371384
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615465}
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/extensions/extension_install_prompt.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/extensions/extension_install_ui_default.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/extensions/extension_install_ui_default.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/extensions/extension_installed_bubble.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/extensions/extension_installed_bubble.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/browser_actions_container.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/browser_app_menu_button.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/toolbar_button.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/chrome/test/data/extensions/api_test/window_update/sizing/test.js
[modify] https://crrev.com/043c95f211872d0739ed6d94e8c54ca2e29757cc/extensions/browser/install/extension_install_ui.h

Blocking: 898632
Labels: -Pri-2 OS-Mac Pri-1 Type-Bug-Regression
It seems that https://chromium-review.googlesource.com/c/chromium/src/+/1331041 is the only change touching extensions.

Adding authors and reverting the change to see whether the builder recovers.
Cc: -fhorschig@google.com rdevlin....@chromium.org bsep@chromium.org
Components: Tests>Fails UI UI>Browser>Toolbar UI>Browser>TabStrip UI>Browser>Bookmarks UI>Browser
Owner: dfried@chromium.org
Status: Assigned (was: Available)
Labels: -Sheriff-Chromium
Mac 10.12 works again. As this issue is assigned, remove it from Sheriff queue.
Status: Fixed (was: Assigned)
Should be fixed in latest.
Was due to incorrect reporting of browser minimum size that caused the browser to grow when it was restored.
@7 Great! If the test is fixed, can we re-enable it? :)
The offending CL was already reverted long ago. So we probably should have turned it back on when that happened. Let's try turning it on and let me know what happens.

Sign in to add a comment