New issue
Advanced search Search tips

Issue 913812 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[LayoutNG] chromepef stopped updating LayoutNG results

Project Member Reported by kojii@chromium.org, Dec 11

Issue description

All LayoutNG perf bots stopped updating after:
  Time added: 2018-12-07T03:08:26.000Z
  Chromium Commit Position range: 614501 - 614517

loading.desktop_layout_ng
https://chromeperf.appspot.com/report?sid=c400e1b1b0810b8990e507ee42fc59145c956c49c1b1c2cef9b86a6c8c3f7ec7

blink_perf.layout_ng
https://chromeperf.appspot.com/report?sid=d50334ccc10a99218d4a7e5b71d290c04082218255b726cb8051cf55bb5c53bf
 
For pinpoint, it should be blink_perf.layout_ng
Oh, you're right, so chromeperf stopped working is a different reason? I'm re-running pinpoint with the correct name to see if it passes.
Components: -Infra>Client>Perf Speed>Dashboard
Summary: [LayoutNG] chromepef stopped updating LayoutNG results (was: [LayoutNG] LayoutNG perf bots stopped working)
Right, thank you, pinpoint is fine. Just chromeperf. Changed summary and components.
Description: Show this description
Labels: -Pri-3 Pri-1
Christian, it looks like no one is watching this label.

Do you happen to know who we can ping?
Cc: dtu@chromium.org nednguyen@chromium.org
Cc: -nednguyen@chromium.org crouleau@chromium.org

Comment 8 by kojii@chromium.org, Jan 20 (2 days ago)

Components: -Speed>Dashboard

Comment 9 by crouleau@chromium.org, Today (8 hours ago)

Components: Speed>Benchmarks>Waterfall
This is the waterfall that I guess would run the tests you're talking about: https://ci.chromium.org/p/chrome/g/chrome.perf.fyi/console

Then I pick linux bot and go to recent run: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/1564

Then I check for "blink_perf.layout_ng" inside the "Benchmarks logs" link inside the "performance_test_suite on NVIDIA GPU on Linux" step. THis is what I see:

{
    "loading.desktop.network_service": [
        "https://logs.chromium.org/v/?s=chrome%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8923601776904655440%2F%2B%2Floading.desktop.network_service_136eb345-e508-4e2a-8527-f29a68bfdaa3"
    ]
}

So looks like blink_perf.layout_ng isn't scheduled to run on that bot.

Comment 10 by crouleau@chromium.org, Today (8 hours ago)

Looks like you may need to edit https://cs.chromium.org/chromium/src/testing/buildbot/chromium.perf.fyi.json?q=loading.desktop.network_service&sq=package:chromium&dr=C&l=276
to re-add blink_perf.layout_ng.

https://cs.chromium.org/chromium/src/tools/perf/core/perf_data_generator.py says:
"Note: chromium.perf.fyi.json is updated manually for now until crbug.com/757933
is complete."

Comment 11 by crouleau@chromium.org, Today (8 hours ago)

Last datapoint for ChromiumPerfFyi/linux-perf-fyi/blink_perf.layout_ng / japanese-kokoro-insert / japanese-kokoro-insert.html was Time added: 2018-12-07T03:08:26.000Z

Comment 12 by crouleau@chromium.org, Today (8 hours ago)

Looks like blink_perf.layout_ng was in https://chromium.googlesource.com/chromium/src/+/b29afe3e41c9af7d236ae4be6793fa9e2cb8a41a . Something changed since September.

Comment 13 by crouleau@chromium.org, Today (8 hours ago)

Comment 14 by crouleau@chromium.org, Today (8 hours ago)

unclear why Ned said:

"The *_layout_ng tests are currently not running (see https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/417), so cleaning them up to prepare
for further refactoring
"

Since that link shows them running successfully. I must be missing something.

Comment 15 by kojii@chromium.org, Today (4 hours ago)

Cc: -kojii@chromium.org jbudorick@chromium.org nednguyen@chromium.org
Thank you for finding it out!

Ned, is it possible to re-enable layout_ng tests? Or if it's problematic for you, is there any options we can keep it running in other ways?

Comment 16 by nedngu...@google.com, Today (3 hours ago)

Cc: -nednguyen@chromium.org
-ned +crouleau

I am no longer work on this project, so Caleb can help you with this

Comment 17 by kojii@chromium.org, Today (3 hours ago)

Thanks for the update.

Caleb, is it just to revert the CL to re-enable it, or is there something else? We would really appreciate if this can be re-enabled.

Sign in to add a comment