New issue
Advanced search Search tips

Issue 913808 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 12
Cc:
tdres...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Cannot LGTM on CL

Project Member Reported by maxlg@chromium.org, Dec 11 
For some reason I can't approve the CLs in gerrit.

I was invited to review this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1354271. But I can't find anywhere I can approve the CL. On the top right corner of the code review panel, I only find "Edit". Pointing to my name under reviewers, it doesn't show votable as it does for other reviewers.

Comment 1 by maxlg@chromium.org, Dec 11

Labels: -Pri-3 Pri-1

Comment 2 by ajp@chromium.org, Dec 11 

Are you a committer in chromium/src? If not, this is working as intended. Only committers can CR+1 / approve a CL. In that case you can still review the CL and provide substantive feedback that people can address, and LGTM or not via textual reply.

This isn't intuitive, which is unfortunate, and something I would like to change long term.

If you are a committer this is a bug.

Comment 3 by maxlg@chromium.org, Dec 12

Status: Fixed (was: Untriaged)
I see. Thanks!

Comment 4 by maxlg@chromium.org, Dec 12

Status: WontFix (was: Fixed)

Comment 5 by maxlg@chromium.org, Dec 12

Cc: tdres...@chromium.org
Status: Assigned (was: WontFix)
Reopen the bug.

Tim've confirmed to me that I am already a committer. So it doesn't make sense that I couldn't approve CLs.
Screen Shot 2018-12-12 at 15.06.22.png
359 KB View Download

Comment 6 by maxlg@chromium.org, Dec 12

Status: Fixed (was: Assigned)
Tim has added me as committer again. Code review +1 is working now. Mark the bug as fixed.
►

Sign in to add a comment