New issue
Advanced search Search tips

Issue 913804 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in v8::internal::compiler::Node::AppendUse

Project Member Reported by ClusterFuzz, Dec 11

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4671680208961536

Fuzzer: afl_v8_wasm_fuzzer
Fuzz target binary: v8_wasm_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  v8::internal::compiler::Node::AppendUse
  v8::internal::compiler::Node::New
  v8::internal::compiler::Graph::NewNodeUnchecked
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=615301:615308

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4671680208961536

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 11

Labels: OS-Chrome
Project Member

Comment 2 by ClusterFuzz, Dec 11

Components: Blink>JavaScript>Compiler
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Dec 11

Labels: Test-Predator-Auto-Owner
Owner: clemensh@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/776c8dd436001521fe5784ba328aff9be7f8c432 ([wasm] Remove redundant buffer fill).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by ClusterFuzz, Dec 11

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://clusterfuzz.com/testcase?key=5181717566193664.
Status: Started (was: Assigned)
Minimal reproducer (produced locally):

load('test/mjsunit/wasm/wasm-constants.js');
load('test/mjsunit/wasm/wasm-module-builder.js');

const builder = new WasmModuleBuilder();
builder.addFunction('main', kSig_v_v).addBody([
  kExprLoop, kWasmStmt,        // loop i32
  /**/ kExprBr, 0x01,          // br depth=1
  /**/ kExprBlock, kWasmStmt,  // block
  /**/ /**/ kExprBr, 0x02,     // br depth=2
  /**/ /**/ kExprEnd,          // end [block]
  /**/ kExprEnd                // end [loop]
]);
builder.instantiate();

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/573e4120fbb1e91871b55f7c68d5cbcfec8563cc

commit 573e4120fbb1e91871b55f7c68d5cbcfec8563cc
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Dec 11 12:01:10 2018

[wasm] Fix return from unreachable code

We hit a DCHECK in the wasm graph builder because the current SSA
environment is unreachable. We were using the wrong block (the target
block) to do the reachability check.

R=titzer@chromium.org

Bug:  chromium:913804 
Change-Id: I4cfd3a0c696fb63903a47e4448362626a524340d
Reviewed-on: https://chromium-review.googlesource.com/c/1371566
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58150}
[modify] https://crrev.com/573e4120fbb1e91871b55f7c68d5cbcfec8563cc/src/wasm/function-body-decoder-impl.h
[add] https://crrev.com/573e4120fbb1e91871b55f7c68d5cbcfec8563cc/test/mjsunit/regress/wasm/regress-913804.js

Status: Fixed (was: Started)
Issue 913840 has been merged into this issue.
Project Member

Comment 10 by ClusterFuzz, Dec 11

ClusterFuzz has detected this issue as fixed in range 58149:58150.

Detailed report: https://clusterfuzz.com/testcase?key=5181717566193664

Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  ssa_env_->reached() in graph-builder-interface.cc
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=58149:58150

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5181717566193664

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Dec 11

Detailed report: https://clusterfuzz.com/testcase?key=5181717566193664

Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  ssa_env_->reached() in graph-builder-interface.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=58128:58129

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5181717566193664

See https://github.com/google/clusterfuzz-tools for more information.
Project Member

Comment 12 by ClusterFuzz, Dec 12

ClusterFuzz has detected this issue as fixed in range 58149:58150.

Detailed report: https://clusterfuzz.com/testcase?key=5181717566193664

Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  ssa_env_->reached() in graph-builder-interface.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=58128:58129
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=58149:58150

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5181717566193664

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Dec 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5719697284399104 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by ClusterFuzz, Dec 12

ClusterFuzz has detected this issue as fixed in range 615537:615552.

Detailed report: https://clusterfuzz.com/testcase?key=4671680208961536

Fuzzer: afl_v8_wasm_fuzzer
Fuzz target binary: v8_wasm_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  v8::internal::compiler::Node::AppendUse
  v8::internal::compiler::Node::New
  v8::internal::compiler::Graph::NewNodeUnchecked
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=615301:615308
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=615537:615552

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4671680208961536

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment