sarien: builder broken building chromeos-initramfs with factory_netboot_ramfs |
||
Issue descriptionThe chromeos-initramfs package is depending on ectool unconditionally. This command is failing: USE=factory_netboot_ramfs emerge-sarien -j chromeos-initramfs Adding a "test -x" check to the recovery_init.sh script itself is easy, adding a dependency check to the makefile is a bit more complicated. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8927504065398454320
,
Dec 11
I have been making changes to incorporate the wilco EC and I suspect one of them resulted in this problem, but I can't figure out exactly how. It is possible that ectool binary was actually building before when there was no ec build target, and now that I am trying to separate cros_ec from wilco_ec it is having problems because it is not building ectool anymore.
,
Dec 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/485c94206c58d87e3612c5c6a36f74e43f55dffe commit 485c94206c58d87e3612c5c6a36f74e43f55dffe Author: Duncan Laurie <dlaurie@google.com> Date: Sun Dec 16 08:58:51 2018 overlay-sarien: Add USE flag to disable ectool Disable the cros_ec_utils flag for this board. BUG= chromium:913766 TEST=emerge-sarien chromeos-base/ec-utils Change-Id: I8f6965a0ca677be0e922a4288929d542d64017b0 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://chromium-review.googlesource.com/1372165 Reviewed-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/485c94206c58d87e3612c5c6a36f74e43f55dffe/overlay-sarien/profiles/base/make.defaults
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/initramfs/+/e043793ce4968d66e0abfc27e4be9c976ba2ccb6 commit e043793ce4968d66e0abfc27e4be9c976ba2ccb6 Author: Duncan Laurie <dlaurie@google.com> Date: Tue Dec 18 00:52:21 2018 initramfs: Conditionally include and use ectool In order to support systems without Chromium EC the recovery script is changed to look for the ectool binary before using it, and the build system is changed to conditionally include the ectool binary only if the "cros_ec" USE flag is set. BUG= chromium:913766 TEST="USE=factory_netboot_ramfs emerge-sarien chromeos-initramfs" CQ-DEPEND=CL:1372284 Change-Id: I0c117cff5bed3dee2f79404c2392961faefe04dd Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://chromium-review.googlesource.com/1372266 Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/e043793ce4968d66e0abfc27e4be9c976ba2ccb6/factory_netboot/Makefile [modify] https://crrev.com/e043793ce4968d66e0abfc27e4be9c976ba2ccb6/recovery/recovery_init.sh
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8596bac3b7c67577b61136ad935e83a7d01636bd commit 8596bac3b7c67577b61136ad935e83a7d01636bd Author: Duncan Laurie <dlaurie@google.com> Date: Tue Dec 18 00:52:21 2018 ectool: Add separate USE flag for ectool In order to support systems without ectool we need a flag that explicitly indicates whether or not it should be present. To do this I split out the ectool build/install process and only call those functions if the USE flag is enabled. By default this flag is true, and it is disabled only on systems that do not use the Chromium EC. The new flag is also used by the initramfs ebuild to provide an indication to the initramfs build system so it can include ectool only if it is present instead of always expecting it to exist. BUG= chromium:913766 TEST="USE=factory_netboot_ramfs emerge-sarien chromeos-initramfs" CQ-DEPEND=CL:1372266 Change-Id: Ia93ff56f07b23465d586cf9b5f7ac0d5b227a246 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://chromium-review.googlesource.com/1372284 Reviewed-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/8596bac3b7c67577b61136ad935e83a7d01636bd/chromeos-base/chromeos-initramfs/chromeos-initramfs-9999.ebuild [modify] https://crrev.com/8596bac3b7c67577b61136ad935e83a7d01636bd/chromeos-base/ec-utils/ec-utils-9999.ebuild
,
Dec 18
This should be fixed now, I will watch the sarien buider. |
||
►
Sign in to add a comment |
||
Comment 1 by hungte@google.com
, Dec 11