New issue
Advanced search Search tips

Issue 913750 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Enable DCHECKS in TestSimpleChromeWorkflow and PFQ chromeos builders

Project Member Reported by achuith@chromium.org, Dec 11

Issue description

Currently chrome in the chromeos PFQ runs VMtests without DCHECKs, which causes problems when it validates a chrome that then triggers DCHECKs in the chromium waterfall.
 
Summary: Enable DCHECKS in TestSimpleChromeWorkflow and PFQ chromeos builders (was: Enable DCHECKS in TestSimpleChromeWorkflow on chromeos builders)
We also need dchecks_always_on=true on all PFQ builders (or at a minimum the kevin builders), since we're introducing hardware (kevins) to the chromium waterfall. 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c4c1b4034ecd72e38b1e54a4c3d363c4859df4

commit f8c4c1b4034ecd72e38b1e54a4c3d363c4859df4
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 11 01:35:27 2019

Disable DCHECKs on the cros VM CQ test bot.

The PFQ currently runs chrome without DCHECKs. This can cause problems when
the PFQ promotes a new version of chrome/an SDK that causes DCHECK crashes,
which shows up only on chromium's bots.

This turns DCHECKs back off until the PFQ also tests them.

Bug: 920471, 913750
Change-Id: I9daa588ac6838fde357fae1c2ed93f48ffa99966
Reviewed-on: https://chromium-review.googlesource.com/c/1404428
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621851}
[modify] https://crrev.com/f8c4c1b4034ecd72e38b1e54a4c3d363c4859df4/tools/mb/mb_config.pyl

Sign in to add a comment