New issue
Advanced search Search tips

Issue 913738 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

File metadata from Drive is not shown in quickview with DriveFS enabled

Project Member Reported by sa...@chromium.org, Dec 11

Issue description

The metadata source switches on whether externalFileUrl is available for a file: if externalFileUrl, the metadata from Drive (or the FSP) is used; otherwise, Files app attempts to extract some metadata from the file itself. externalFileUrl is not set for files from DriveFS so the wrong metadata provider is being used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5b7717b7137efdd1ef344dcd0348a6211f6fd57

commit b5b7717b7137efdd1ef344dcd0348a6211f6fd57
Author: Sam McNally <sammc@chromium.org>
Date: Tue Dec 11 05:41:28 2018

Use file metadata from DriveFS in quickview when available.

MetadataBoxController uses the availability of externalFileUrl in file
metadata to decide whether to obtain metadata via
ExternalMetadataProvider or by reading the file. With DriveFS,
externalFileUrl is not set but ExternalMetadataProvider should be used
for fetching metadata. Also use alternateUrl (which is only set for
Drive files) to detect files where this metadata provider should be
used.

Also skip FSP metadata requests when none of the metadata fields are
available via the FSP API.

Bug:  913738 ,  587231 
Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8
Reviewed-on: https://chromium-review.googlesource.com/c/1370154
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615437}
[modify] https://crrev.com/b5b7717b7137efdd1ef344dcd0348a6211f6fd57/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/b5b7717b7137efdd1ef344dcd0348a6211f6fd57/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
[modify] https://crrev.com/b5b7717b7137efdd1ef344dcd0348a6211f6fd57/ui/file_manager/integration_tests/file_manager/quick_view.js

Labels: Merge-Request-72
Status: Fixed (was: Started)
Requesting merge to 72. I've manually tested with 73.0.3638.0/11393.0.0 Canary.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 13

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Approved-72
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd47cf3e14265cec98590d3a30ec0ecd26c8827f

commit cd47cf3e14265cec98590d3a30ec0ecd26c8827f
Author: Sam McNally <sammc@chromium.org>
Date: Tue Dec 18 22:31:47 2018

Use file metadata from DriveFS in quickview when available.

MetadataBoxController uses the availability of externalFileUrl in file
metadata to decide whether to obtain metadata via
ExternalMetadataProvider or by reading the file. With DriveFS,
externalFileUrl is not set but ExternalMetadataProvider should be used
for fetching metadata. Also use alternateUrl (which is only set for
Drive files) to detect files where this metadata provider should be
used.

Also skip FSP metadata requests when none of the metadata fields are
available via the FSP API.

Bug:  913738 ,  587231 
Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8
Reviewed-on: https://chromium-review.googlesource.com/c/1370154
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615437}(cherry picked from commit b5b7717b7137efdd1ef344dcd0348a6211f6fd57)
Reviewed-on: https://chromium-review.googlesource.com/c/1382656
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#455}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/cd47cf3e14265cec98590d3a30ec0ecd26c8827f/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/cd47cf3e14265cec98590d3a30ec0ecd26c8827f/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
[modify] https://crrev.com/cd47cf3e14265cec98590d3a30ec0ecd26c8827f/ui/file_manager/integration_tests/file_manager/quick_view.js

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/cd47cf3e14265cec98590d3a30ec0ecd26c8827f

Commit: cd47cf3e14265cec98590d3a30ec0ecd26c8827f
Author: sammc@chromium.org
Commiter: sammc@chromium.org
Date: 2018-12-18 22:31:47 +0000 UTC

Use file metadata from DriveFS in quickview when available.

MetadataBoxController uses the availability of externalFileUrl in file
metadata to decide whether to obtain metadata via
ExternalMetadataProvider or by reading the file. With DriveFS,
externalFileUrl is not set but ExternalMetadataProvider should be used
for fetching metadata. Also use alternateUrl (which is only set for
Drive files) to detect files where this metadata provider should be
used.

Also skip FSP metadata requests when none of the metadata fields are
available via the FSP API.

Bug:  913738 ,  587231 
Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8
Reviewed-on: https://chromium-review.googlesource.com/c/1370154
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615437}(cherry picked from commit b5b7717b7137efdd1ef344dcd0348a6211f6fd57)
Reviewed-on: https://chromium-review.googlesource.com/c/1382656
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#455}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment