Issue metadata
Sign in to add a comment
|
File metadata from Drive is not shown in quickview with DriveFS enabled |
||||||||||||||||||||
Issue descriptionThe metadata source switches on whether externalFileUrl is available for a file: if externalFileUrl, the metadata from Drive (or the FSP) is used; otherwise, Files app attempts to extract some metadata from the file itself. externalFileUrl is not set for files from DriveFS so the wrong metadata provider is being used.
,
Dec 13
Requesting merge to 72. I've manually tested with 73.0.3638.0/11393.0.0 Canary.
,
Dec 13
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd47cf3e14265cec98590d3a30ec0ecd26c8827f commit cd47cf3e14265cec98590d3a30ec0ecd26c8827f Author: Sam McNally <sammc@chromium.org> Date: Tue Dec 18 22:31:47 2018 Use file metadata from DriveFS in quickview when available. MetadataBoxController uses the availability of externalFileUrl in file metadata to decide whether to obtain metadata via ExternalMetadataProvider or by reading the file. With DriveFS, externalFileUrl is not set but ExternalMetadataProvider should be used for fetching metadata. Also use alternateUrl (which is only set for Drive files) to detect files where this metadata provider should be used. Also skip FSP metadata requests when none of the metadata fields are available via the FSP API. Bug: 913738 , 587231 Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8 Reviewed-on: https://chromium-review.googlesource.com/c/1370154 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615437}(cherry picked from commit b5b7717b7137efdd1ef344dcd0348a6211f6fd57) Reviewed-on: https://chromium-review.googlesource.com/c/1382656 Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#455} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/cd47cf3e14265cec98590d3a30ec0ecd26c8827f/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc [modify] https://crrev.com/cd47cf3e14265cec98590d3a30ec0ecd26c8827f/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js [modify] https://crrev.com/cd47cf3e14265cec98590d3a30ec0ecd26c8827f/ui/file_manager/integration_tests/file_manager/quick_view.js
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd47cf3e14265cec98590d3a30ec0ecd26c8827f Commit: cd47cf3e14265cec98590d3a30ec0ecd26c8827f Author: sammc@chromium.org Commiter: sammc@chromium.org Date: 2018-12-18 22:31:47 +0000 UTC Use file metadata from DriveFS in quickview when available. MetadataBoxController uses the availability of externalFileUrl in file metadata to decide whether to obtain metadata via ExternalMetadataProvider or by reading the file. With DriveFS, externalFileUrl is not set but ExternalMetadataProvider should be used for fetching metadata. Also use alternateUrl (which is only set for Drive files) to detect files where this metadata provider should be used. Also skip FSP metadata requests when none of the metadata fields are available via the FSP API. Bug: 913738 , 587231 Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8 Reviewed-on: https://chromium-review.googlesource.com/c/1370154 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615437}(cherry picked from commit b5b7717b7137efdd1ef344dcd0348a6211f6fd57) Reviewed-on: https://chromium-review.googlesource.com/c/1382656 Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#455} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 11