New issue
Advanced search Search tips

Issue 913733 link

Starred by 1 user
Status: Assigned
Owner:
zhongyi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Support migration to server preferred address.

Project Member Reported by zhongyi@chromium.org, Dec 11 
Add support in client to migrate a QUIC connection to the server preferred address after receiving SHLO. 

The client should probe the server preferred address, and migrate to that address when the probe is successful. 

This should be available for all the OS versions.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdacb825658504dcd1879f6a530361b7f2880ab0

commit fdacb825658504dcd1879f6a530361b7f2880ab0
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Tue Dec 11 22:49:15 2018

Change the API of QuicConnectivityProbingManager::Delegate methods.

No behavior change, just prepare the connectivity probing manager to probe for server preferred address.

Bug: 913733
Change-Id: Ib4bb47c80cdc42edf8241bf63369b1e6e0e50c14
Reviewed-on: https://chromium-review.googlesource.com/c/1370952
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615707}
[modify] https://crrev.com/fdacb825658504dcd1879f6a530361b7f2880ab0/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/fdacb825658504dcd1879f6a530361b7f2880ab0/net/quic/quic_chromium_client_session.h
[modify] https://crrev.com/fdacb825658504dcd1879f6a530361b7f2880ab0/net/quic/quic_connectivity_probing_manager.cc
[modify] https://crrev.com/fdacb825658504dcd1879f6a530361b7f2880ab0/net/quic/quic_connectivity_probing_manager.h
[modify] https://crrev.com/fdacb825658504dcd1879f6a530361b7f2880ab0/net/quic/quic_connectivity_probing_manager_test.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b280d098fb322b6296e77596d700b303b67a04b

commit 7b280d098fb322b6296e77596d700b303b67a04b
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Thu Dec 13 02:54:41 2018

Some cosmetic change for QUIC connection migration code.

Change the QuicConnectivityProbingManager::CancelProbing to take peer
address and enforce a strong match when cancel running probing. Also fix
some comments to prepare QuicConnectivityProbingManager to probe for
server preferred address. No behavior change.

Bug: 913733
Change-Id: I234e892c2839babd0bb0c76917db218976ca5179
Reviewed-on: https://chromium-review.googlesource.com/c/1373035
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616180}
[modify] https://crrev.com/7b280d098fb322b6296e77596d700b303b67a04b/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/7b280d098fb322b6296e77596d700b303b67a04b/net/quic/quic_chromium_client_session.h
[modify] https://crrev.com/7b280d098fb322b6296e77596d700b303b67a04b/net/quic/quic_connectivity_probing_manager.cc
[modify] https://crrev.com/7b280d098fb322b6296e77596d700b303b67a04b/net/quic/quic_connectivity_probing_manager.h
[modify] https://crrev.com/7b280d098fb322b6296e77596d700b303b67a04b/net/quic/quic_connectivity_probing_manager_test.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4747b37f49abb887500ec2292de86978befcd7c

commit f4747b37f49abb887500ec2292de86978befcd7c
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Fri Dec 14 01:19:06 2018

Add a boolean in QuicConnectivityProbingManager to track if probing is active.

We used to rely on the |network_| == kInvalidNetworkHandle check to determine if there's any active probing. This is preparing for probe server preferred address on non-Android platform where network_ may be invalid during active probing. No behavior change.

Bug: 913733
Change-Id: I280da06961b4faac0cf685ed9d994f37db4702f1
Reviewed-on: https://chromium-review.googlesource.com/c/1374792
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616545}
[modify] https://crrev.com/f4747b37f49abb887500ec2292de86978befcd7c/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/f4747b37f49abb887500ec2292de86978befcd7c/net/quic/quic_chromium_client_session.h
[modify] https://crrev.com/f4747b37f49abb887500ec2292de86978befcd7c/net/quic/quic_connectivity_probing_manager.cc
[modify] https://crrev.com/f4747b37f49abb887500ec2292de86978befcd7c/net/quic/quic_connectivity_probing_manager.h
[modify] https://crrev.com/f4747b37f49abb887500ec2292de86978befcd7c/net/quic/quic_connectivity_probing_manager_test.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2724dce25b712dd8ec49babaaeb96695ebbe798

commit e2724dce25b712dd8ec49babaaeb96695ebbe798
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Fri Dec 14 22:30:29 2018

Rename NetLogEventType for connectivity probing.

This change also cleans up the annotation comments.

Bug: 913733
Change-Id: I9075c61bdcad9a041d758d4235cf82dade55b30e
Reviewed-on: https://chromium-review.googlesource.com/c/1374970
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616853}
[modify] https://crrev.com/e2724dce25b712dd8ec49babaaeb96695ebbe798/net/log/net_log_event_type_list.h
[modify] https://crrev.com/e2724dce25b712dd8ec49babaaeb96695ebbe798/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/e2724dce25b712dd8ec49babaaeb96695ebbe798/net/quic/quic_connectivity_probing_manager.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b6c68009aebb7afd1b6857b9b0b63eebc256c5

commit a0b6c68009aebb7afd1b6857b9b0b63eebc256c5
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Mon Dec 17 19:01:44 2018

Add two tests for probe server preferred address in ConnectivityProbingManager.

Bug: 913733
Change-Id: I66519e9ab948a6bc5cd748021a7a195636200447
Reviewed-on: https://chromium-review.googlesource.com/c/1378969
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617175}
[modify] https://crrev.com/a0b6c68009aebb7afd1b6857b9b0b63eebc256c5/net/quic/quic_connectivity_probing_manager.cc
[modify] https://crrev.com/a0b6c68009aebb7afd1b6857b9b0b63eebc256c5/net/quic/quic_connectivity_probing_manager_test.cc
►

Sign in to add a comment