New issue
Advanced search Search tips

Issue 913725 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Drag and drop of hosted docs onto the browser doesn't open them with DriveFS enabled

Project Member Reported by sa...@chromium.org, Dec 10

Issue description

The unopenable virtual file is dropped instead of the URL to access the doc.
 
Summary: Drag and drop of hosted docs onto the browser doesn't open them with DriveFS enabled (was: Drag and drop of hosted docs onto the browser doesn't open them with DriveFS)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015014924bd3def93f8c8335b66ac3f2014f85c9

commit 015014924bd3def93f8c8335b66ac3f2014f85c9
Author: Sam McNally <sammc@chromium.org>
Date: Tue Dec 11 04:35:52 2018

Provide the alternate URL as the drag and drop URL for hosted docs.

With the old Drive integration, all files were accessed via
externalfile: URLs. Those for hosted docs redirected to the actual URL
for accessing that doc. With DriveFS, real file: URLs are used so no
externalfile: URLs exist. The drag and drop code populates the File and,
if available, the externalfile: URL in the DataTransfer. For hosted docs
under DriveFS, this is insufficient as the files are not openable.
However, the alternateUrl is the URL needed to access the hosted doc so
substitute it for the externalfile: URL for hosted docs.

Bug:  913725 
Change-Id: Ib9456042e1e864b378b71db404e1ea406959b1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1370152
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615428}
[modify] https://crrev.com/015014924bd3def93f8c8335b66ac3f2014f85c9/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/015014924bd3def93f8c8335b66ac3f2014f85c9/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

Labels: Merge-Request-72
Status: Fixed (was: Started)
Requesting merge to 72. I've manually tested with 73.0.3638.0/11393.0.0 Canary.
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 13

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Approved-72
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 18

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36cef230eedfa2c3e0d5094a3a95808e817eeb0d

commit 36cef230eedfa2c3e0d5094a3a95808e817eeb0d
Author: Sam McNally <sammc@chromium.org>
Date: Tue Dec 18 22:30:48 2018

Provide the alternate URL as the drag and drop URL for hosted docs.

With the old Drive integration, all files were accessed via
externalfile: URLs. Those for hosted docs redirected to the actual URL
for accessing that doc. With DriveFS, real file: URLs are used so no
externalfile: URLs exist. The drag and drop code populates the File and,
if available, the externalfile: URL in the DataTransfer. For hosted docs
under DriveFS, this is insufficient as the files are not openable.
However, the alternateUrl is the URL needed to access the hosted doc so
substitute it for the externalfile: URL for hosted docs.

Bug:  913725 
Change-Id: Ib9456042e1e864b378b71db404e1ea406959b1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1370152
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615428}(cherry picked from commit 015014924bd3def93f8c8335b66ac3f2014f85c9)
Reviewed-on: https://chromium-review.googlesource.com/c/1382655
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#454}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/36cef230eedfa2c3e0d5094a3a95808e817eeb0d/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/36cef230eedfa2c3e0d5094a3a95808e817eeb0d/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

Labels: CommitLog-Audit-Violation Merge-Without-Approval M-72
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 36cef230eedfa2c3e0d5094a3a95808e817eeb0d was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/36cef230eedfa2c3e0d5094a3a95808e817eeb0d

Commit: 36cef230eedfa2c3e0d5094a3a95808e817eeb0d
Author: sammc@chromium.org
Commiter: sammc@chromium.org
Date: 2018-12-18 22:30:48 +0000 UTC

Provide the alternate URL as the drag and drop URL for hosted docs.

With the old Drive integration, all files were accessed via
externalfile: URLs. Those for hosted docs redirected to the actual URL
for accessing that doc. With DriveFS, real file: URLs are used so no
externalfile: URLs exist. The drag and drop code populates the File and,
if available, the externalfile: URL in the DataTransfer. For hosted docs
under DriveFS, this is insufficient as the files are not openable.
However, the alternateUrl is the URL needed to access the hosted doc so
substitute it for the externalfile: URL for hosted docs.

Bug:  913725 
Change-Id: Ib9456042e1e864b378b71db404e1ea406959b1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1370152
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615428}(cherry picked from commit 015014924bd3def93f8c8335b66ac3f2014f85c9)
Reviewed-on: https://chromium-review.googlesource.com/c/1382655
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#454}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment