libassistant: compiler BUILD.gn needs to disable thinLTO caching with Chrome OS |
|||||
Issue descriptionThere is a known bug with THinLTO caching, with LLD, that can cause bad images to be built. The chrome compiler BUILD.gn file has been updated to disable ThinLTO caching with LLD in Chrome OS; the same change needs to be made in the libassistant compiler BUILD.gn file. Here's the Chrome CL: https://chromium-review.googlesource.com/c/chromium/src/+/1345537 This needs to be done ASAP, as we are in the process of migrating Chrome OS to use LLD, and this may result in odd libassistant failures.
,
Dec 10
https://libassistant-internal-review.git.corp.google.com/c/standalone/src/+/72543 Uploaded the exact cl. for future reference, the repo in chromium tree is a mirror, but you can git push to the real remote from chromium tree. For this particular one, I used git push sso://libassistant-internal.googlesource.com/standalone/src.git HEAD:refs/for/master
,
Dec 12
,
Dec 12
,
Dec 22
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/assistant/+/0c3ac6af07c0cb63adc6fc7f170e2a0f14c3d5c1 commit 0c3ac6af07c0cb63adc6fc7f170e2a0f14c3d5c1 Author: Xiaohui Chen <xiaohuic@google.com> Date: Fri Jan 18 21:48:11 2019
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/66c0e4335c1b02c93de8cca228ccabe69eaaa24a commit 66c0e4335c1b02c93de8cca228ccabe69eaaa24a Author: Xiaohui Chen <xiaohuic@google.com> Date: Fri Jan 18 22:08:45 2019
,
Jan 18
(4 days ago)
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc36572d319711922c3cad8b30fa4653fd51a8c7 commit fc36572d319711922c3cad8b30fa4653fd51a8c7 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Jan 19 00:41:27 2019 Roll src-internal 641f6a4faeab..574e57a00200 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/641f6a4faeab..574e57a00200 Created with: gclient setdep -r src-internal@574e57a00200 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:913707 TBR=mmoss@chromium.org Change-Id: I1ad3c8588853d1bab9b7835a45608a13e2461aa0 Reviewed-on: https://chromium-review.googlesource.com/c/1422640 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624385} [modify] https://crrev.com/fc36572d319711922c3cad8b30fa4653fd51a8c7/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cmt...@chromium.org
, Dec 10