New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 913702

Blocking:
issue 904337



Sign in to add a comment
link

Issue 913704: Need tsan tot bot

Reported by thakis@chromium.org, Dec 10 Project Member

Issue description

Looks like we don't have a tsan llvm tot bot, we should add one: tsan issues look like they got in the way of the current roll,  issue 913702 
 

Comment 1 by prasadv@google.com, Dec 11

Components: -Infra Infra>Labs
Chrome infra bug triage: 
  I think the component of this bug should be Infra>Labs? If not, feel free to change to other components. Thanks.

Comment 2 by prasadv@google.com, Dec 11

Status: Available (was: Untriaged)

Comment 3 by vhang@chromium.org, Dec 11

Can you give me more details on what you need?
- Can you use a bot in one of the swarming pools?
- What type of bot do you need?
  - OS version
  - GCE, baremetal, or VM?

Comment 4 by thakis@chromium.org, Dec 11

Sorry, this wasn't supposed to be a Labs bug, I figured I'd file a separate labs bug that blocks this some time today.

But since someone changed this to a labs bug, I suppose let's use this bug.

A standard linux bot, but as fast as possible (I think this means baremetal).

The bot will be very similar to https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTLinuxMSan , so if it could get similar hardware (or even run in that pool, and we add one more gce instance there) that would be fine for example.

Comment 5 by vhang@chromium.org, Dec 12

Status: Assigned (was: Available)
All the bots in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTLinuxMSan are GCE instances managed by MP.  The process to get more resources is self managed now.  See: 

https://groups.google.com/a/google.com/forum/#!searchin/chrome-infra/machine$20provider%7Csort:date/chrome-infra/OsXFpRSaToc/MwZ6muI-CwAJ

Comment 7 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c71e7501fc15e8f8eebd8c9e7629646159f0ce73

commit c71e7501fc15e8f8eebd8c9e7629646159f0ce73
Author: Nico Weber <thakis@chromium.org>
Date: Thu Dec 13 17:40:27 2018

Add recipe for new ToTLinuxTSan bot.

I'm trying to add the bot only on LUCI, so no masters/ change.

TBR=hans
Bug:  913704 
Change-Id: I3e2dfe9f64f5d1495e8afc8d9a47d65494966709
Reviewed-on: https://chromium-review.googlesource.com/c/1376189
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

[modify] https://crrev.com/c71e7501fc15e8f8eebd8c9e7629646159f0ce73/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py

Comment 9 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/ee62e96c73f38e03db7f2d5dd18fea50e0f44727

commit ee62e96c73f38e03db7f2d5dd18fea50e0f44727
Author: Nico Weber <thakis@chromium.org>
Date: Thu Dec 13 18:42:21 2018

Comment 11 by thakis@chromium.org, Dec 13

Status: Fixed (was: Assigned)
Bot exists. Hopefully it'll demonstrate  issue 904337 .

Comment 12 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441

commit f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 13:32:59 2018

Disable the two blink_heap_unittests that fail under tsan and run suite on tsan bot.

Disables HeapTest.CrossThreadWeakPersistent and HeapTest.ThreadedStrongification
under TSan.

Bug: 843511,915200,831674, 913704 
Change-Id: I6ab71b83fa937f739a57452a97bd43ef6375bf2c
Reviewed-on: https://chromium-review.googlesource.com/c/1377517
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616652}
[modify] https://crrev.com/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/f8ab18bbd3fa087a3fdd0eb76353eca1a8ffa441/third_party/blink/renderer/platform/heap/heap_test.cc

Comment 13 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae13cd99937742648f3d4c2bedeaa2ea667521a

commit dae13cd99937742648f3d4c2bedeaa2ea667521a
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 13:56:26 2018

Make ToTLinuxTSan test list more similar to main waterfall TSan bot.

Stop running:
- browser_tests and derivative network_service_browser_tests (doesn't pass under tsan)
- headless_browsertests

Give content_browsertest 5 shards, give interactive_ui_tests 6 shards, give
net_unittests 4 shards

Bug:  913704 
Change-Id: Ibc146a48b6a177e835e0354802b182843541ae6a
Reviewed-on: https://chromium-review.googlesource.com/c/1377518
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616658}
[modify] https://crrev.com/dae13cd99937742648f3d4c2bedeaa2ea667521a/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/dae13cd99937742648f3d4c2bedeaa2ea667521a/testing/buildbot/test_suite_exceptions.pyl

Comment 14 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbc2838d0dc12de17f79bb2a760ad859fc41a76

commit 8fbc2838d0dc12de17f79bb2a760ad859fc41a76
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 16:00:57 2018

Disable the three sync_integration_tests that fail under tsan and run suite on tsan bot.

Looks like all the protobuf issues went away, maybe due to #612796.

Only some tests still fail:
- TwoClientCustomPassphraseSyncTest.ClientsCanSyncDataWhenScryptEncryptionEnabledInOne
- EnableDisableSingleClientTest.DoesNotRedownloadAfterKeepDataWithStandaloneTransport
- SingleClientDirectorySyncTest.StopThenDisableDeletesDirectory

Disable them under tsan and run the suite on the tsan bot.

Bug:  852002 , 915219 ,843511, 913704 
Change-Id: I862a93a4669c2dbd57ded99c9704528201f687b9
Reviewed-on: https://chromium-review.googlesource.com/c/1377327
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616693}
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/chrome/browser/sync/test/integration/two_client_custom_passphrase_sync_test.cc
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/8fbc2838d0dc12de17f79bb2a760ad859fc41a76/testing/buildbot/test_suite_exceptions.pyl

Comment 15 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408a49aae07247ac04ec9569ffd0348f9a8584b8

commit 408a49aae07247ac04ec9569ffd0348f9a8584b8
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 21:00:10 2018

Disable network_service_interactive_ui_tests, network_service_content_browsertests on ToTLinuxTSan

interactive_ui_tests and content_browsertests have extra shards on TSan,
but the network_service_ versions don't since they're disabled on the main
TSan bot for resource reasons. Rather than giving them more shards on the ToT
bot, make the ToT bot more like the main TSan and disable these two test suites
there too.

network_service_interactive_ui_tests used to take 30 min to run in the current
setup, network_service_content_browsertests took 45 min.

TBR=hans

Bug:  913704 
Change-Id: Ib3c0755b58d51582d119365829e0cbbf53380120
Reviewed-on: https://chromium-review.googlesource.com/c/1378635
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616816}
[modify] https://crrev.com/408a49aae07247ac04ec9569ffd0348f9a8584b8/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/408a49aae07247ac04ec9569ffd0348f9a8584b8/testing/buildbot/test_suite_exceptions.pyl

Sign in to add a comment