New issue
Advanced search Search tips

Issue 913691 link

Starred by 2 users
Status: Started
Owner:
jimmyxgong@chromium.org
Cc:
baileyberro@chromium.org
zentaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Dormant state for mounted shares

Project Member Reported by jimmyxgong@chromium.org, Dec 10 
Mounted shares currently unmount themselves if a call to Remount fails. Examples of cases where this can occur is if a user switches to a different network or if they log out. By introducing a new dormant state to mounts, we hold mounts in an inactive state until a call to ReadDir is successful.

Steps to implement:
  1. Flip flag to keep only non-authenticated shares in memory. 
     Authenticated shares will temporarily not be persisted in memory.
  2. Implement dormant non-authenticated shares, so that they can still
     remount upon a successful ReadDir.
  3. Implement dormant authenticated shares.
  4. Implement UI that pops up upon clicking on a dormant authenticated 
     share that allows users to reenter credentials.
  5. Flip flags back to persist authenticated shares in memory.

Comment 1 by jimmyxgong@chromium.org, Dec 12

Cc: zentaro@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ea7b454b089379865cad9b4e8cd8bfc33ee0a628

commit ea7b454b089379865cad9b4e8cd8bfc33ee0a628
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Thu Jan 03 02:13:52 2019

smbprovider: Remove unmounting shares on Remount errors

- Remount will remount any shares regardless if they can reached on
  the network or not.
- Previously, Remount would unmount shares that could not be accessed.
- This change will put shares in a dormant state, which allows mounts to
  be remounted.
- Updated unit test to reflect this change.

BUG=chromium:913691
TEST=unit test, end to end

Change-Id: I7f23db7c106ac6e8d07045a669e079162108b39d
Reviewed-on: https://chromium-review.googlesource.com/1375050
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ea7b454b089379865cad9b4e8cd8bfc33ee0a628/smbprovider/smbprovider.cc
[modify] https://crrev.com/ea7b454b089379865cad9b4e8cd8bfc33ee0a628/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/ea7b454b089379865cad9b4e8cd8bfc33ee0a628/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/ea7b454b089379865cad9b4e8cd8bfc33ee0a628/smbprovider/mount_manager.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/53bdcd22ebc99f4ce1e552a2634b23223fdf0be2

commit 53bdcd22ebc99f4ce1e552a2634b23223fdf0be2
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Thu Jan 03 02:13:53 2019

smbprovider: Add non-const iterator to IdMap

- Added an overloaded non-const iterator to IdMap.
- Used to be able to access and mutate the value inside IdMap.
- Updated previous iterators to use const auto rather than auto.
- Added unit tests to reflect this change.

BUG=chromium:913691
TEST=unit tests

Change-Id: Id1c341f53bffc49a00849d0362c1e0523010b3aa
Reviewed-on: https://chromium-review.googlesource.com/1379019
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/53bdcd22ebc99f4ce1e552a2634b23223fdf0be2/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/53bdcd22ebc99f4ce1e552a2634b23223fdf0be2/smbprovider/mount_tracker.cc
[modify] https://crrev.com/53bdcd22ebc99f4ce1e552a2634b23223fdf0be2/smbprovider/id_map.h
[modify] https://crrev.com/53bdcd22ebc99f4ce1e552a2634b23223fdf0be2/smbprovider/id_map_test.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bfe6755b8dd97814cda1a00831cd6990bd881448

commit bfe6755b8dd97814cda1a00831cd6990bd881448
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Thu Jan 03 02:13:53 2019

smbprovider: Add UpdateMountCredentialsOptionsProto

- UpdateMountCredentialsOptionsProto is used for updating a mount's
  credentials.
- This is necessary as users will need to be able to update their
  credentials if a share has changed its credentials.
- Updated unit tests to reflect this change.

BUG=chromium:913691
TEST=emerges + unit tests

Change-Id: Iaeeecfc158b1dab216ac16109e255ec92b9ab861
Reviewed-on: https://chromium-review.googlesource.com/1379020
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/system_api/dbus/smbprovider/directory_entry.proto
[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/smbprovider/proto.h
[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/system_api/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/smbprovider/smbprovider_test_helper.cc
[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/smbprovider/proto_test.cc
[modify] https://crrev.com/bfe6755b8dd97814cda1a00831cd6990bd881448/smbprovider/proto.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/92399f836f3990b26ef90518504a99fd82254c21

commit 92399f836f3990b26ef90518504a99fd82254c21
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Thu Jan 03 02:13:54 2019

smbprovider: Add SmbProvider::UpdateMountCredentials

- UpdateMountCredentials will update a mount's credentials regardless if
  the new credentials are correct or not.
- This function is in preparation for the implementation of dormant shares.
  If a share's credentials are altered or remounted without saved
  credentials, users will be required to enter the new credentials upon a
  call to readdir.
- Added UpdateMountCredentials to DBUS.
- Updated unit tests to reflect this change.

BUG=chromium:913691
TEST=unit tests

Change-Id: I49c57db5211744c42bee563abda91c0599a2066c
Reviewed-on: https://chromium-review.googlesource.com/1379021
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/smbprovider.h
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/mount_tracker.h
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/mount_tracker.cc
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/mount_manager.cc
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/smbprovider.cc
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/smbprovider_test_helper.cc
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/mount_manager.h
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/92399f836f3990b26ef90518504a99fd82254c21/smbprovider/mount_tracker_test.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b1dc231b146ada6a1374fc710ca8675c34ee7ac

commit 7b1dc231b146ada6a1374fc710ca8675c34ee7ac
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Thu Jan 03 22:58:01 2019

Stop remounting SMB shares that require credentials

- Shares that require credentials are no longer remembered.
- Previously, all shares would be persisted regardless of whether or
  not they had credentials.
- A future CL will resume persistence on all shares.

Bug: chromium:913691
Test: emerges
Change-Id: I7dd5290d8b5af60bf6a9d14ac69e2bef5ba6c1c2
Reviewed-on: https://chromium-review.googlesource.com/c/1372915
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619796}
[modify] https://crrev.com/7b1dc231b146ada6a1374fc710ca8675c34ee7ac/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/7b1dc231b146ada6a1374fc710ca8675c34ee7ac/chrome/browser/chromeos/smb_client/smb_service.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e820af9a40a5a7667ff61ba50b95e70304f64381

commit e820af9a40a5a7667ff61ba50b95e70304f64381
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Fri Jan 04 01:37:50 2019

Add UpdateMountCredentials SmbProviderClient

- Adds UpdateMountCredentials to SmbProviderClient.
- This function will interact with Dbus to call CrOS's
  SmbProvider::UpdateMountCredentials.
- Updated FakeSmbProviderClient.

Bug: chromium:913691
Test: emerges
Change-Id: I6311bc0d38282dacd659f82348189f96d29526bb
Reviewed-on: https://chromium-review.googlesource.com/c/1388029
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619852}
[modify] https://crrev.com/e820af9a40a5a7667ff61ba50b95e70304f64381/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/e820af9a40a5a7667ff61ba50b95e70304f64381/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/e820af9a40a5a7667ff61ba50b95e70304f64381/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/e820af9a40a5a7667ff61ba50b95e70304f64381/chromeos/dbus/smb_provider_client.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/86bc628255ad1c9421c8385bbe38b489139e461e

commit 86bc628255ad1c9421c8385bbe38b489139e461e
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Fri Jan 04 20:46:37 2019

smbprovider: Move public functions of MountTrackerTest to protected

BUG=chromium:913691
TEST=emerges + unit tests

Change-Id: I91ae130a4d0df9cd421fb74793526fe6cf08802a
Reviewed-on: https://chromium-review.googlesource.com/1387711
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/86bc628255ad1c9421c8385bbe38b489139e461e/smbprovider/mount_tracker_test.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/686715ce7dff281facf835037526b20b4cf73d23

commit 686715ce7dff281facf835037526b20b4cf73d23
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jan 08 04:40:16 2019

Add RequestCredentialsCallback to SmbProvider

- Adds a RequestCredentialsCallback to the ProviderInterfce for SMB so
that a RequestCredentialsCallback can be passed down to each
SmbFileSystem instance during construction.

Bug: chromium:913691
Change-Id: I7d66fae81e6c50f3867b7af393aa5bdf2ec27a6d
Reviewed-on: https://chromium-review.googlesource.com/c/1396677
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620621}
[modify] https://crrev.com/686715ce7dff281facf835037526b20b4cf73d23/chrome/browser/chromeos/smb_client/smb_file_system.h
[modify] https://crrev.com/686715ce7dff281facf835037526b20b4cf73d23/chrome/browser/chromeos/smb_client/smb_provider.cc
[modify] https://crrev.com/686715ce7dff281facf835037526b20b4cf73d23/chrome/browser/chromeos/smb_client/smb_provider.h
[modify] https://crrev.com/686715ce7dff281facf835037526b20b4cf73d23/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/686715ce7dff281facf835037526b20b4cf73d23/chrome/browser/chromeos/smb_client/smb_service.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6183034407e8ddb1e796de40bc28dafb1ee529d8

commit 6183034407e8ddb1e796de40bc28dafb1ee529d8
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jan 08 19:12:53 2019

Pass RequestCredentialsCallback to SmbFileSystem during construction

- A RequestCredentialsCallback is injected in SmbFileSystem via the ctor
so that when neccessary, SmbFileSystem can request credentials for a
mounted share.

Bug: chromium:913691
Change-Id: I4c16dba4d054f2cb6200b6e55f7dbbaf6c875be0
Reviewed-on: https://chromium-review.googlesource.com/c/1396678
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620827}
[modify] https://crrev.com/6183034407e8ddb1e796de40bc28dafb1ee529d8/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/6183034407e8ddb1e796de40bc28dafb1ee529d8/chrome/browser/chromeos/smb_client/smb_file_system.h
[modify] https://crrev.com/6183034407e8ddb1e796de40bc28dafb1ee529d8/chrome/browser/chromeos/smb_client/smb_provider.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52bf5577bd118f73fa70993887921179e4245d32

commit 52bf5577bd118f73fa70993887921179e4245d32
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jan 08 19:28:30 2019

Add RequestUpdatedCredentials method to SmbFileSystem

- Adds helper methods for requesting updated credentials to
SmbFileSystem.
- Adds getter for the share's mount path

Bug: chromium:913691
Change-Id: Iac0235b66d7dc16d7b5fc0c3ce0af59a8c48849d
Reviewed-on: https://chromium-review.googlesource.com/c/1396534
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620833}
[modify] https://crrev.com/52bf5577bd118f73fa70993887921179e4245d32/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/52bf5577bd118f73fa70993887921179e4245d32/chrome/browser/chromeos/smb_client/smb_file_system.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f179e2535fafc36fda2ca0bc4d34877232dfcf

commit 02f179e2535fafc36fda2ca0bc4d34877232dfcf
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Jan 09 00:00:20 2019

Add OpenRequestCredentialsDialog method stub to SmbService

- Adds OpenRequestCredentialsDialog method stub to SmbService
- Adds the update_credential_replies_ map, used for storing closures to
run upon successfully updating a mounts credential.

Bug: chromium:913691
Change-Id: I1a9091ccc0ed54afa8fdcbfa1571b8a6d360d72a
Reviewed-on: https://chromium-review.googlesource.com/c/1396535
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620950}
[modify] https://crrev.com/02f179e2535fafc36fda2ca0bc4d34877232dfcf/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/02f179e2535fafc36fda2ca0bc4d34877232dfcf/chrome/browser/chromeos/smb_client/smb_service.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4cf031c3d19a6917fb915f58d5c48aecd777b2d

commit f4cf031c3d19a6917fb915f58d5c48aecd777b2d
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jan 11 01:08:20 2019

Introduce Smb Credentials Dialog

- SmbCredentialsDialog is used for updating the credentials of a mounted
share.
- This dialog is opened when a user attempts to read a directory, and the
ReadDirectory fails due to incorrect login.

Bug: chromium:913691
Change-Id: I59aa2990654b389db8e822183f98880aaec5bab7
Reviewed-on: https://chromium-review.googlesource.com/c/1396536
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621841}
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/browser_resources.grd
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/resources/chromeos/smb_shares/BUILD.gn
[add] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/resources/chromeos/smb_shares/smb_credentials_dialog.html
[add] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/resources/chromeos/smb_shares/smb_credentials_dialog.js
[add] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/resources/chromeos/smb_shares/smb_credentials_dialog_container.html
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/ui/webui/chromeos/smb_shares/smb_credentials_dialog.cc
[add] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/ui/webui/chromeos/smb_shares/smb_credentials_dialog.h
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/ui/webui/chromeos/smb_shares/smb_handler.cc
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/browser/ui/webui/chromeos/smb_shares/smb_handler.h
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/chrome/common/webui_url_constants.h
[modify] https://crrev.com/f4cf031c3d19a6917fb915f58d5c48aecd777b2d/ui/webui/resources/cr_components/chromeos/smb_shares/smb_browser_proxy.js
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8261841582dca13065a5ff78e14f6e1aff7b4c7c

commit 8261841582dca13065a5ff78e14f6e1aff7b4c7c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Jan 12 16:31:33 2019

Implement UpdateCredentials on SmbService

- Implements the public UpdateCredentials method on SmbService. This
method is called when a user clicks "save" in the Smb Credential Dialog.
- Calls the smbprovider daemon via D-Bus to update the credentials for
the share.

Bug: chromium:913691
Change-Id: I696464f5d52eb81d2b9770108835e8780a833779
Reviewed-on: https://chromium-review.googlesource.com/c/1396697
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622315}
[modify] https://crrev.com/8261841582dca13065a5ff78e14f6e1aff7b4c7c/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/8261841582dca13065a5ff78e14f6e1aff7b4c7c/chrome/browser/chromeos/smb_client/smb_service.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7d2671aaa18bd861bc7a8e15bf5fd07513080e1

commit e7d2671aaa18bd861bc7a8e15bf5fd07513080e1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sun Jan 13 15:45:43 2019

Request new credentials for share when authentication fails on a ReadDir

- When a ReadDirectory fails because of invalid permissions, the user
will be prompted for credentials.
- Once the credentials are successfully updated, the ReadDirectory is
reattempted.

Bug: chromium:913691
Change-Id: I6198a6ec23e2e5865759232720d69e83578094b5
Reviewed-on: https://chromium-review.googlesource.com/c/1396700
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622351}
[modify] https://crrev.com/e7d2671aaa18bd861bc7a8e15bf5fd07513080e1/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/e7d2671aaa18bd861bc7a8e15bf5fd07513080e1/chrome/browser/chromeos/smb_client/smb_file_system.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b3e0b411621db582f8a573a6c060584683aaca3

commit 2b3e0b411621db582f8a573a6c060584683aaca3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jan 14 21:07:50 2019

Resume remounting SMB shares that require credentials

Now that reauthenticating to shares that require credentials is
possible, resume remembering & remounting shares that require credentials

Bug: chromium:913691
Change-Id: Ia55a78653e922b1e84ae3147158da03b16b8d639
Reviewed-on: https://chromium-review.googlesource.com/c/1396701
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622598}
[modify] https://crrev.com/2b3e0b411621db582f8a573a6c060584683aaca3/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/2b3e0b411621db582f8a573a6c060584683aaca3/chrome/browser/chromeos/smb_client/smb_service.h
►

Sign in to add a comment