[WPT Import] Importer failing because "android_blink_rel" has "wrong master/builder name" |
||
Issue descriptionExample: https://chromium-review.googlesource.com/c/chromium/src/+/1370323/ git cl try-results --gerrit -i 1370323 -p 1 Wrong master/builder name: android_blink_rel In the JSON output, the android_blink_rel build has url "null", which causes the subsequent result fetching to fail: Received HTTP status 400 loading "https://test-results.appspot.com/testfile?buildnumber=None&callback=ADD_RESULTS&builder=android_blink_rel&name=full_results.json". The immediate fix would be to abort early if the url of a build is null. Also cc jbudorick: would https://crrev.com/c/1369637 fix this?
,
Dec 11
oy vey. I turned down android_blink_rel 2 months ago, but I neglected to restart the master. It was restarted on Friday for the first time since. The buildbot version is now *gone*. That CL might fix the issue, or there might be another CL required. Either way, you should be able to run luci.chromium.try:android_blink_rel explicitly now (though it may take the Choose Trybots plugin a bit to find it).
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8099a1eb65c74427e876b8e056a3a28fb8e60c10 commit 8099a1eb65c74427e876b8e056a3a28fb8e60c10 Author: Robert Ma <robertma@chromium.org> Date: Tue Dec 11 02:54:21 2018 [blinkpy] Make buildbot.fetch_results return None if build is invalid `fetch_results` is only used to fetch results from a specific run, so we should be able to safely assume that builder_name and build_number are not None. The same check is also added to `get_step_name` to prevent misuse. On the other hand, `fetch_layout_test_results` may be used to fetch the latest accumulated results, where URLs are constructed from `results_url`, so we don't add the check to either of these functions. Bug: 913687 Change-Id: Ie8b96fd22ea8e7edc804296689b11411e36ae82a Reviewed-on: https://chromium-review.googlesource.com/c/1371021 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615404} [modify] https://crrev.com/8099a1eb65c74427e876b8e056a3a28fb8e60c10/third_party/blink/tools/blinkpy/common/net/buildbot.py [modify] https://crrev.com/8099a1eb65c74427e876b8e056a3a28fb8e60c10/third_party/blink/tools/blinkpy/common/net/buildbot_unittest.py
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79d671a0fab2b784324cb3b9d8d37800b5c7a2c9 commit 79d671a0fab2b784324cb3b9d8d37800b5c7a2c9 Author: John Budorick <jbudorick@chromium.org> Date: Tue Dec 11 15:32:58 2018 blinkpy: switch to luci.chromium.try version of android_blink_rel. Bug: 731964 , 913687 Change-Id: Ie7de1a0aba1316b8916219afb766b18e95dc5549 Reviewed-on: https://chromium-review.googlesource.com/c/1372026 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615531} [modify] https://crrev.com/79d671a0fab2b784324cb3b9d8d37800b5c7a2c9/third_party/blink/tools/blinkpy/common/config/builders.json
,
Dec 11
today's WPT autoroller CLs appear happier. Anything left here?
,
Dec 11
No, this should be fixed now. Thanks, John! |
||
►
Sign in to add a comment |
||
Comment 1 by robertma@chromium.org
, Dec 10{u'bucket': u'master.tryserver.chromium.android', u'buildbucket_id': u'8927501853289283152', u'builder_name': u'android_blink_rel', u'created_ts': u'1544467795056409', u'experimental': False, u'failure_reason': u'INVALID_BUILD_DEFINITION', u'result': u'FAILURE', u'status': u'COMPLETED', u'tags': [u'builder:android_blink_rel', u'buildset:patch/gerrit/chromium-review.googlesource.com/1370323/1', u'master:tryserver.chromium.android', u'user_agent:git_cl_try'], u'url': None}