[autofill] Base64 decode when parsing profile validity info. |
|||||||
Issue descriptionThe server generated profile validity priority pref must be encoded as a base64 encoded serialized proto within a pref string value. Currently the code is expecting a raw serialized proto in the value. This can't be handled by the pref code; so, while the sync of the value is currently working, it never gets exposed via prefs.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf9f80b0a223258d1583a664bbeb9f4501330df5 commit cf9f80b0a223258d1583a664bbeb9f4501330df5 Author: Roger McFarlane <rogerm@chromium.org> Date: Wed Dec 12 13:49:03 2018 [autofill] Base64 decode when parsing profile validity info. The server generated profile validity priority pref is encoded as a base64 encoded serialized proto within a pref string value. Misc: - Fixes the name of a member variable (was missing trailing _) - Move impl of a method whose address is taken from .h to .cc Bug: 913685 Change-Id: I6ddf194a54d536289b1fcb5a95067d24cb642f4c Reviewed-on: https://chromium-review.googlesource.com/c/1371006 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615874} [modify] https://crrev.com/cf9f80b0a223258d1583a664bbeb9f4501330df5/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/cf9f80b0a223258d1583a664bbeb9f4501330df5/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/cf9f80b0a223258d1583a664bbeb9f4501330df5/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/cf9f80b0a223258d1583a664bbeb9f4501330df5/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/cf9f80b0a223258d1583a664bbeb9f4501330df5/components/autofill/core/common/autofill_prefs.cc
,
Dec 12
,
Dec 12
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b53af61e0d6a7e19da131a848023378d06b9ace0 commit b53af61e0d6a7e19da131a848023378d06b9ace0 Author: Roger McFarlane <rogerm@chromium.org> Date: Wed Dec 12 20:58:47 2018 [autofill] Base64 decode when parsing profile validity info. The server generated profile validity priority pref is encoded as a base64 encoded serialized proto within a pref string value. Misc: - Fixes the name of a member variable (was missing trailing _) - Move impl of a method whose address is taken from .h to .cc Bug: 913685 Change-Id: I6ddf194a54d536289b1fcb5a95067d24cb642f4c Reviewed-on: https://chromium-review.googlesource.com/c/1371006 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615874}(cherry picked from commit cf9f80b0a223258d1583a664bbeb9f4501330df5) Reviewed-on: https://chromium-review.googlesource.com/c/1374575 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#308} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b53af61e0d6a7e19da131a848023378d06b9ace0/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/b53af61e0d6a7e19da131a848023378d06b9ace0/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/b53af61e0d6a7e19da131a848023378d06b9ace0/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/b53af61e0d6a7e19da131a848023378d06b9ace0/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/b53af61e0d6a7e19da131a848023378d06b9ace0/components/autofill/core/common/autofill_prefs.cc
,
Dec 12
,
Dec 12
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b53af61e0d6a7e19da131a848023378d06b9ace0 Commit: b53af61e0d6a7e19da131a848023378d06b9ace0 Author: rogerm@chromium.org Commiter: rogerm@chromium.org Date: 2018-12-12 20:58:47 +0000 UTC [autofill] Base64 decode when parsing profile validity info. The server generated profile validity priority pref is encoded as a base64 encoded serialized proto within a pref string value. Misc: - Fixes the name of a member variable (was missing trailing _) - Move impl of a method whose address is taken from .h to .cc Bug: 913685 Change-Id: I6ddf194a54d536289b1fcb5a95067d24cb642f4c Reviewed-on: https://chromium-review.googlesource.com/c/1371006 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615874}(cherry picked from commit cf9f80b0a223258d1583a664bbeb9f4501330df5) Reviewed-on: https://chromium-review.googlesource.com/c/1374575 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#308} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rogerm@chromium.org
, Dec 10