New issue
Advanced search Search tips

Issue 913676 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add a `skylab resize-pools` command

Project Member Reported by pprabhu@chromium.org, Dec 10

Issue description

To be used by deputies to resize DUT pools in Skylab.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aba01cde7a95eaeb64c9b6c269578a8d26df0b31

commit aba01cde7a95eaeb64c9b6c269578a8d26df0b31
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Dec 18 19:08:20 2018

crosskylabadmin: refactor EnsurePoolHealthy

Refactor out some helper functions

BUG= chromium:913676 

Change-Id: I44a2f62989922362d2a09379a8123049e5a11d5f
Reviewed-on: https://chromium-review.googlesource.com/c/1373978
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19638}
[modify] https://crrev.com/aba01cde7a95eaeb64c9b6c269578a8d26df0b31/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory.go

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/08361a3702e0922e5b4788cc71e8f83c1d30adcd

commit 08361a3702e0922e5b4788cc71e8f83c1d30adcd
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed Dec 19 18:28:08 2018

crosskylabadmin: Simplify fleet.PoolChange assertions in unittests

BUG= chromium:913676 

Change-Id: I7a8ebf8563f49e6075a0b19aeb2149ba66672b67
Reviewed-on: https://chromium-review.googlesource.com/c/1382682
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19671}
[modify] https://crrev.com/08361a3702e0922e5b4788cc71e8f83c1d30adcd/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory_test.go

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/03debb02bcfd7835be44a375d381411999a26c49

commit 03debb02bcfd7835be44a375d381411999a26c49
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed Dec 19 20:57:39 2018

crosskylabadmin: add inventory.ResizePool

BUG= chromium:913676 

Change-Id: I890f99d7706b9f2c12b0cbea9c347773f0c71134
Reviewed-on: https://chromium-review.googlesource.com/c/1370552
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19678}
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.pb.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/pool_balancer.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/tracker.pb.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/tasker.pb.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/validation.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.proto
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory_test.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventoryserver_dec.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.mock.pb.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/app/config/config.pb.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/trackerserver_dec.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/taskerserver_dec.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/common.pb.go
[modify] https://crrev.com/03debb02bcfd7835be44a375d381411999a26c49/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/pb.discovery.go

Components: -Infra>Client>ChromeOS>Test Infra>Client>ChromeOS>Test>Platform
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/09047097208fb6ce67fa3b7d3598990e75b14c45

commit 09047097208fb6ce67fa3b7d3598990e75b14c45
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Jan 04 00:04:30 2019

skylab: Extract UserErrorReporter

As requested on CL:1372214.

BUG= chromium:913676 

Change-Id: Ib852339df054a68f3f5c0af8e0e0e55420c8d6b0
Reviewed-on: https://chromium-review.googlesource.com/c/1391393
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19770}
[modify] https://crrev.com/09047097208fb6ce67fa3b7d3598990e75b14c45/go/src/infra/cmd/skylab/internal/cmd/common.go
[modify] https://crrev.com/09047097208fb6ce67fa3b7d3598990e75b14c45/go/src/infra/cmd/skylab/internal/cmd/ensure-pool-healthy.go

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/074bb031426a238dd38b67314312d334d9d13ae7

commit 074bb031426a238dd38b67314312d334d9d13ae7
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Jan 04 18:18:06 2019

skylab: Add `resize-pool` subcommand

BUG= chromium:913676 

Change-Id: Ib7bde2a2f2330cbb1a1d160b707a8ddd1a52e555
Reviewed-on: https://chromium-review.googlesource.com/c/1391394
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19777}
[add] https://crrev.com/074bb031426a238dd38b67314312d334d9d13ae7/go/src/infra/cmd/skylab/internal/cmd/resize-pool.go
[modify] https://crrev.com/074bb031426a238dd38b67314312d334d9d13ae7/go/src/infra/cmd/skylab/main.go

Status: Fixed (was: Assigned)

Sign in to add a comment