New issue
Advanced search Search tips

Issue 913670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile external_metadata_provider_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73d8deada12823ed921f1860a27ea0a2af383489

commit 73d8deada12823ed921f1860a27ea0a2af383489
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 23:07:48 2018

Closure compile external_metadata_provider_unittest

 - remove external_metadata_provider_unittest.html
 - move the closure_compile BUILD.gn rule to the front
 - add BUILD rules to auto-generate and compile the unittest
 - fix Closure compile errors and auto-format the code

No change in test behavior.

Bug:  913670 
Change-Id: Ib188e13cd5e143142006a00865a69547556a0a22
Reviewed-on: https://chromium-review.googlesource.com/c/1370149
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615304}
[modify] https://crrev.com/73d8deada12823ed921f1860a27ea0a2af383489/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/73d8deada12823ed921f1860a27ea0a2af383489/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/a22f10309f888b61e2e6b8398e2d90f133159c55/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
[modify] https://crrev.com/73d8deada12823ed921f1860a27ea0a2af383489/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment